Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --rm to docker run in run_docker_build.sh ? #909

Open
pkgw opened this issue Oct 23, 2018 · 0 comments · May be fixed by #1753
Open

Add --rm to docker run in run_docker_build.sh ? #909

pkgw opened this issue Oct 23, 2018 · 0 comments · May be fixed by #1753

Comments

@pkgw
Copy link
Contributor

pkgw commented Oct 23, 2018

When I'm doing local testing of Linux builds, each invocation of .circleci/run_docker_build.sh leaves behind a dead Docker container when the build finishes (successfully or not). These are a bit tedious to clean up. I have also not found that it is that important to preserve the containers, since all of the useful state is in the build_artifacts directory that has its own life outside of the container. So, should we add a --rm flag to the docker run command to cause it to automatically remove the containers when they're done running?

If what I wrote above is all correct, I really don't think there's any downside, but perhaps I'm missing something.

@mikemhenry mikemhenry linked a pull request Jul 28, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant