Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional information to linter for noarch packages can't have skips with selectors #2149

Open
matthewfeickert opened this issue Nov 20, 2024 · 0 comments

Comments

@matthewfeickert
Copy link
Member

matthewfeickert commented Nov 20, 2024

In conda-forge/staged-recipes#28268 (comment) @ocefpaf gave a very useful short summary of the conditions for a noarch: python build to be allowed to fail on Windows in conda-forge/staged-recipes when I forgot the workflow (which is don't leave in a skip: true # [win] but remove any skip and let it fail on Windows with an explanation, given that noarch: python build on feedstock are just Linux x86 jobs).

Copying the summary from the post:

Noarch don't need to be built for all archs, we save resources that way. If this is a noarch that really needs to skip Windows we need to know:

  1. If the reason for the skip is a missing dependency, then remove this, let it fail, and the package won't be installable on Windows until that dependency is available.
  2. If the reason is b/c the package will get built but won't work on Windows, then you need to do a OS-noarch. Check our docs on how to do that.
  3. If the reason is some other failure, then you may be creating a broken package by using noarch and we need to fix that failure first.

I think this would be very useful to add to the linter output beyond the existing

"`noarch` packages can't have skips with selectors. If "
"the selectors are necessary, please remove "
f"`noarch: {noarch_value}`."

noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

as I think without this information most people assume that the linter is telling them they can't have a noarch package because they assume that they can't have any failures, which results in extra builds that aren't needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant