Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: internal linter error: 'CommentedMap' object has no attribute 'split' #2165

Open
h-vetinari opened this issue Nov 24, 2024 · 6 comments

Comments

@h-vetinari
Copy link
Member

As of conda-forge/torchaudio-feedstock@488d678 in conda-forge/torchaudio-feedstock#6, the linter fails with

>conda smithy lint --conda-forge recipe
Traceback (most recent call last):
  File "E:\miniforge\envs\builder\Scripts\conda-smithy-script.py", line 9, in <module>
    sys.exit(main())
             ^^^^^^
  File "E:\miniforge\envs\builder\Lib\site-packages\conda_smithy\cli.py", line 767, in main
    args.subcommand_func(args)
  File "E:\miniforge\envs\builder\Lib\site-packages\conda_smithy\cli.py", line 645, in __call__
    lints, hints = linter.main(
                   ^^^^^^^^^^^^
  File "E:\miniforge\envs\builder\Lib\site-packages\conda_smithy\lint_recipe.py", line 697, in main
    results, hints = lintify_meta_yaml(
                     ^^^^^^^^^^^^^^^^^^
  File "E:\miniforge\envs\builder\Lib\site-packages\conda_smithy\lint_recipe.py", line 235, in lintify_meta_yaml
    run_conda_forge_specific(
  File "E:\miniforge\envs\builder\Lib\site-packages\conda_smithy\lint_recipe.py", line 544, in run_conda_forge_specific
    dep = rq.split(" ")[0].strip()
          ^^^^^^^^
AttributeError: 'CommentedMap' object has no attribute 'split'
@h-vetinari
Copy link
Member Author

@adament had been commenting on zulip about a closely-related issue. I've just now tested an install from main (thus including #2157), but the issue still remains.

@wolfv
Copy link
Member

wolfv commented Nov 24, 2024

@h-vetinari do you need help fixing this?

@h-vetinari
Copy link
Member Author

@h-vetinari do you need help fixing this?

That would be very welcome, thank you! I haven't started looking into this (and am currently busy elsewhere), I just opened the issue after I ran into an internal linter error. :)

@wolfv
Copy link
Member

wolfv commented Nov 24, 2024

Fixed in #2166

@h-vetinari
Copy link
Member Author

Fix confirmed! :) thank you very much! 🙏

@h-vetinari
Copy link
Member Author

Still running into this with smithy 3.44.9 (despite the fix from #2166 which landed in 3.44.8) in conda-forge/torchaudio-feedstock#12

(builder) E:\conda-forge\torchaudio-feedstock>conda smithy lint recipe --conda-forge
Traceback (most recent call last):
  File "E:\miniforge\envs\builder\Scripts\conda-smithy-script.py", line 9, in <module>
    sys.exit(main())
             ^^^^^^
  File "E:\miniforge\envs\builder\Lib\site-packages\conda_smithy\cli.py", line 767, in main
    args.subcommand_func(args)
  File "E:\miniforge\envs\builder\Lib\site-packages\conda_smithy\cli.py", line 645, in __call__
    lints, hints = linter.main(
                   ^^^^^^^^^^^^
  File "E:\miniforge\envs\builder\Lib\site-packages\conda_smithy\lint_recipe.py", line 727, in main
    results, hints = lintify_meta_yaml(
                     ^^^^^^^^^^^^^^^^^^
  File "E:\miniforge\envs\builder\Lib\site-packages\conda_smithy\lint_recipe.py", line 235, in lintify_meta_yaml
    run_conda_forge_specific(
  File "E:\miniforge\envs\builder\Lib\site-packages\conda_smithy\lint_recipe.py", line 574, in run_conda_forge_specific
    dep = rq.split(" ")[0].strip()
          ^^^^^^^^
AttributeError: 'CommentedMap' object has no attribute 'split'

@h-vetinari h-vetinari reopened this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants