Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Circle CI config from recipe #599

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Drop Circle CI config from recipe #599

wants to merge 3 commits into from

Conversation

conda-forge-linter
Copy link

@conda-forge-linter conda-forge-linter commented Nov 15, 2022 •
edited by jakirkham
Loading

Hi! This is the friendly automated conda-forge-webservice.

I've rerendered the recipe as instructed in #598.

Here's a checklist to do before merging.

  • Bump the build number if needed.

Fixes #598
Fixes #600

@conda-forge-linter conda-forge-linter mentioned this pull request Nov 15, 2022
Closed
@conda-forge-linter
Copy link
Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@jakirkham jakirkham changed the title MNT: rerender Drop Circle CI config from recipe Nov 15, 2022
mbargull
mbargull requested changes Nov 15, 2022
View reviewed changes
Copy link
Member

@mbargull mbargull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since rerendering updated the compilers on Windows, we should probably bump the build number.

@jakirkham
Copy link
Member

Actually would prefer to put this into a PR that is already going in. Seems silly just to include this change alone (though suppose we could)

@mbargull
Copy link
Member

Yes, makes sense.
(Foremost, I added the review to avoid an early merge -- I'm a fan of the "draft PR" feature ;).)

@mbargull mbargull marked this pull request as draft November 15, 2022 19:42
@jakirkham
Copy link
Member

Yeah it was a bot PR. So it didn't start as a draft, but yeah marking it as such makes sense

@nikhilweee
Copy link
Contributor

Happy to add this in #597

@jakirkham
Copy link
Member

That would be great! Thank you 🙏

@nikhilweee
Copy link
Contributor

Done

@nikhilweee nikhilweee mentioned this pull request Nov 16, 2022
Merged
5 tasks
@mattip
Copy link

mattip commented Feb 1, 2023

I think this can be closed.

@jakirkham
Copy link
Member

Why? It appears to be unaddressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbargull mbargull mbargull requested changes

@chrisburr chrisburr Awaiting requested review from chrisburr chrisburr is a code owner

@isuruf isuruf Awaiting requested review from isuruf isuruf is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@katietz katietz Awaiting requested review from katietz katietz is a code owner

@mingwandroid mingwandroid Awaiting requested review from mingwandroid

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@pelson pelson Awaiting requested review from pelson pelson is a code owner

@scopatz scopatz Awaiting requested review from scopatz scopatz is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove CircleCI config from recipe @conda-forge-admin, please re-render
6 participants
@conda-forge-linter @jakirkham @mbargull @nikhilweee @mattip @conda-forge-admin