minor adjustments

Author: lenadax

CHANGES.rst

@@ -4,7 +4,17 @@ Changes
 0.5.0 (unreleased)
 ------------------
 
-- No changes yet.
+- Move ``AjaxDestroy`` to ``ajaxdestroy`` module to prevent circular import dependency.
+  [lenadax]
+
+- Fix widgets not being fully destroyed if rendered within an ``Overlay`` inside body.
+  [lenadax]
+
+- Modify ``AjaxDestroy`` parse method to prevent DOM memory leaks.
+  [lenadax]
+
+- Replace svg spinner with Bootstrap5 spinner.
+  [lenadax]
 
 
 0.4.0 (2024-02-12)

src/ajax.js

@@ -1120,7 +1120,7 @@ export class Ajax extends AjaxUtil {
 }
 
 let ajax = new Ajax();
-export {ajax, AjaxDestroy};
+export {ajax, AjaxDestroy}; // ensure delivery within ajax
 
 $.fn.tsajax = function() {
     ajax.bind(this);

src/ajaxdestroy.js

@@ -24,7 +24,7 @@ export class AjaxDestroy extends Parser {
             let evts = attrs['ajax:bind'];
             $(node).off(evts);
         }
-        if (window.bootstrap) {
+        if (window.bootstrap && window.bootstrap !== undefined) {
             let dd = window.bootstrap.Dropdown.getInstance(node);
             let tt = window.bootstrap.Tooltip.getInstance(node);
             if (dd) {

src/overlay.js

@@ -23,10 +23,10 @@ export class Overlay extends Events {
     }
 
     compile() {
-        let zIndex = 1055; // default bootstrap modal z-index
-        zIndex += $('.modal:visible').length; // increase zindex based on currently open modals
+        let z_index = 1055; // default bootstrap modal z-index
+        z_index += $('.modal:visible').length; // increase zindex based on currently open modals
         compile_template(this, `
-            <div class="modal-wrapper position-absolute" t-elem="wrapper" style="z-index: ${zIndex}">
+            <div class="modal-wrapper position-absolute" t-elem="wrapper" style="z-index: ${z_index}">
               <div class="modal-backdrop opacity-25" t-elem="backdrop"></div>
               <div class="modal ${this.css}" id="${this.uid}" t-elem="elem">
                 <div class="modal-dialog">

tests/test_overlay.js

@@ -52,14 +52,12 @@ QUnit.module('treibstoff.overlay', hooks => {
 
         let body = $('body');
         assert.true(body.hasClass('modal-open'));
-        // assert.deepEqual(body.css('overflow-x'), 'hidden');
 
         ol.close();
         assert.deepEqual(container.children().length, 0);
         assert.false(ol.elem.is(':visible'));
 
         assert.false(body.hasClass('modal-open'));
-        // assert.deepEqual(body.css('overflow-x'), 'auto');
     });
 
     QUnit.test('Test Overlay events', assert => {