Skip to content

Commit 4dd5aef

Browse files
committed
cleanup
1 parent 3184ce1 commit 4dd5aef

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

src/ssr/handle.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ export class AjaxHandle extends AjaxUtil {
4242
context.html(payload);
4343
this.ajax.bind(context);
4444
}
45-
context = null;
4645
}
4746

4847
next(operations) {

tests/test_ajaxdestroy.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@ import $ from 'jquery';
22
import {AjaxDestroy} from '../src/ssr/destroy.js';
33
import {ajax_destroy} from '../src/ssr/destroy.js';
44
import {register_ajax_destroy_handle} from '../src/ssr/destroy.js';
5-
import {deregister_ajax_destroy_handle} from '../src/ssr/destroy.js';
5+
import {unregister_ajax_destroy_handle} from '../src/ssr/destroy.js';
66
import {spinner} from '../src/spinner.js';
7+
import {ajax, AjaxDispatcher} from '../src/bundle.js';
78

89
QUnit.module('treibstoff.ajaxdestroy', hooks => {
910
let container;
@@ -111,10 +112,10 @@ QUnit.module('treibstoff.ajaxdestroy', hooks => {
111112
register_ajax_destroy_handle(custom_callback2);
112113
parser.walk(elem[0]);
113114
assert.verifySteps(['destroy', 'custom1', 'custom2']);
114-
// deregister callbacks
115+
// unregister callbacks
115116
elem[0]._ajax_attached = [inst]; // reattach instance
116-
deregister_ajax_destroy_handle(custom_callback1);
117-
deregister_ajax_destroy_handle(custom_callback2);
117+
unregister_ajax_destroy_handle(custom_callback1);
118+
unregister_ajax_destroy_handle(custom_callback2);
118119
parser.walk(elem[0]);
119120
assert.verifySteps(['destroy']);
120121
});
@@ -151,10 +152,10 @@ QUnit.module('treibstoff.ajaxdestroy', hooks => {
151152
register_ajax_destroy_handle(custom_callback2);
152153
ajax_destroy(elem);
153154
assert.verifySteps(['destroy', 'custom1', 'custom2']);
154-
// deregister callbacks
155+
// unregister callbacks
155156
elem[0]._ajax_attached = [inst]; // reattach instance
156-
deregister_ajax_destroy_handle(custom_callback1);
157-
deregister_ajax_destroy_handle(custom_callback2);
157+
unregister_ajax_destroy_handle(custom_callback1);
158+
unregister_ajax_destroy_handle(custom_callback2);
158159
ajax_destroy(elem);
159160
assert.verifySteps(['destroy']);
160161
});

treibstoff/bundle/treibstoff.bundle.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -590,13 +590,13 @@ var ts = (function (exports, $) {
590590
);
591591
}
592592
}
593-
function deregister_ajax_destroy_handle(callback) {
593+
function unregister_ajax_destroy_handle(callback) {
594594
const index = destroy_handles.indexOf(callback);
595595
if (index > -1) {
596596
destroy_handles.splice(index, 1);
597597
} else {
598598
console.warn(
599-
'Warning: Ajax destroy handle is not registered and cannot be deregistered: '
599+
'Warning: Ajax destroy handle is not registered and cannot be unregistered: '
600600
+ callback
601601
);
602602
}
@@ -1288,7 +1288,6 @@ var ts = (function (exports, $) {
12881288
context.html(payload);
12891289
this.ajax.bind(context);
12901290
}
1291-
context = null;
12921291
}
12931292
next(operations) {
12941293
if (!operations || !operations.length) {
@@ -2141,7 +2140,6 @@ var ts = (function (exports, $) {
21412140
exports.create_listener = create_listener;
21422141
exports.create_svg_elem = create_svg_elem;
21432142
exports.deprecate = deprecate;
2144-
exports.deregister_ajax_destroy_handle = deregister_ajax_destroy_handle;
21452143
exports.extract_number = extract_number;
21462144
exports.get_elem = get_elem;
21472145
exports.get_overlay = get_overlay;
@@ -2167,6 +2165,7 @@ var ts = (function (exports, $) {
21672165
exports.show_warning = show_warning;
21682166
exports.spinner = spinner;
21692167
exports.svg_ns = svg_ns;
2168+
exports.unregister_ajax_destroy_handle = unregister_ajax_destroy_handle;
21702169
exports.uuid4 = uuid4;
21712170

21722171
Object.defineProperty(exports, '__esModule', { value: true });

treibstoff/bundle/treibstoff.bundle.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)