From 477342c19ac5edfa7d8440eee9cb1b32b4499024 Mon Sep 17 00:00:00 2001 From: Adam Simon Date: Fri, 10 Nov 2023 13:35:57 +0100 Subject: [PATCH] Fix maxInitWaitTime tests by adding a bit of tolerance to timing checks --- test/ConfigCatClientTests.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/ConfigCatClientTests.ts b/test/ConfigCatClientTests.ts index f930f17..6ba180a 100644 --- a/test/ConfigCatClientTests.ts +++ b/test/ConfigCatClientTests.ts @@ -568,7 +568,7 @@ describe("ConfigCatClient", () => { const actualValue = await client.getValueAsync("debug", false); const elapsedMilliseconds: number = new Date().getTime() - startDate; - assert.isAtLeast(elapsedMilliseconds, maxInitWaitTimeSeconds * 1000); + assert.isAtLeast(elapsedMilliseconds, (maxInitWaitTimeSeconds * 1000) - 10); // 10 ms for tolerance assert.isAtMost(elapsedMilliseconds, (maxInitWaitTimeSeconds * 1000) + 50); // 50 ms for tolerance assert.equal(actualValue, false); }); @@ -605,7 +605,7 @@ describe("ConfigCatClient", () => { const state = await client.waitForReady(); const elapsedMilliseconds: number = new Date().getTime() - startDate; - assert.isAtLeast(elapsedMilliseconds, maxInitWaitTimeSeconds * 1000); + assert.isAtLeast(elapsedMilliseconds, (maxInitWaitTimeSeconds * 1000) - 10); // 10 ms for tolerance assert.isAtMost(elapsedMilliseconds, (maxInitWaitTimeSeconds * 1000) + 50); // 50 ms for tolerance assert.equal(state, ClientReadyState.NoFlagData); @@ -631,7 +631,7 @@ describe("ConfigCatClient", () => { const state = await client.waitForReady(); const elapsedMilliseconds: number = new Date().getTime() - startDate; - assert.isAtLeast(elapsedMilliseconds, maxInitWaitTimeSeconds * 1000); + assert.isAtLeast(elapsedMilliseconds, (maxInitWaitTimeSeconds * 1000) - 10); // 10 ms for tolerance assert.isAtMost(elapsedMilliseconds, (maxInitWaitTimeSeconds * 1000) + 50); // 50 ms for tolerance assert.equal(state, ClientReadyState.HasCachedFlagDataOnly);