Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Implement vault-java-driver's Vault.prefixPathDepth parameter #247

Open
Dugong42 opened this issue Mar 14, 2024 · 0 comments

Comments

@Dugong42
Copy link
Contributor

Summary

Hi, this issue concerns the Hashicorp Vault provider.

The Vault provider currently supports a vault.prefixpath parameter. This parameter is used by vault-java-driver in a way that is non-intuitive regarding its name.

Motivation

The driver's VaultConfig.prefixPath (string) parameter is not used as an actual prefix by the driver.
Instead, it is used to determine the path depth (levels of forward slashes) at which a "/data" key is inserted in the case of kv v2 secrets. This non-intuitive feature is somewhat documented in the javadoc and I've created the #246 PR to document it here as well to help client integration.

Meanwhile the VaultConfig.prefixPathDepth (number) parameter is clearly documented with examples in the driver's README. It has a name coherent with its usage which does not depend on an implicit behaviour. IMHO this parameter should be available as the preferred solution.

Proposed solution

I suggest that a vault.prefixpathdepth parameter (mapped to VaultConfig.prefixPathDepth) be implemented as an optional alternative to vault.prefixpath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant