You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, this issue concerns the Hashicorp Vault provider.
The Vault provider currently supports a vault.prefixpath parameter. This parameter is used by vault-java-driver in a way that is non-intuitive regarding its name.
Motivation
The driver's VaultConfig.prefixPath (string) parameter is not used as an actual prefix by the driver.
Instead, it is used to determine the path depth (levels of forward slashes) at which a "/data" key is inserted in the case of kv v2 secrets. This non-intuitive feature is somewhat documented in the javadoc and I've created the #246 PR to document it here as well to help client integration.
Meanwhile the VaultConfig.prefixPathDepth (number) parameter is clearly documented with examples in the driver's README. It has a name coherent with its usage which does not depend on an implicit behaviour. IMHO this parameter should be available as the preferred solution.
Proposed solution
I suggest that a vault.prefixpathdepth parameter (mapped to VaultConfig.prefixPathDepth) be implemented as an optional alternative to vault.prefixpath.
The text was updated successfully, but these errors were encountered:
Summary
Hi, this issue concerns the Hashicorp Vault provider.
The Vault provider currently supports a
vault.prefixpath
parameter. This parameter is used by vault-java-driver in a way that is non-intuitive regarding its name.Motivation
The driver's
VaultConfig.prefixPath
(string) parameter is not used as an actual prefix by the driver.Instead, it is used to determine the path depth (levels of forward slashes) at which a "/data" key is inserted in the case of kv v2 secrets. This non-intuitive feature is somewhat documented in the javadoc and I've created the #246 PR to document it here as well to help client integration.
Meanwhile the
VaultConfig.prefixPathDepth
(number) parameter is clearly documented with examples in the driver's README. It has a name coherent with its usage which does not depend on an implicit behaviour. IMHO this parameter should be available as the preferred solution.Proposed solution
I suggest that a
vault.prefixpathdepth
parameter (mapped toVaultConfig.prefixPathDepth
) be implemented as an optional alternative tovault.prefixpath
.The text was updated successfully, but these errors were encountered: