Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KSQL-12787] Fix master build #10596

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[KSQL-12787] Fix master build #10596

wants to merge 9 commits into from

Conversation

VedarthConfluent
Copy link
Member

Description

Use jakarta.xml.bind to import DatatypeConverter

Testing done

Tested locally

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

ksqldb-common/pom.xml Show resolved Hide resolved
@VedarthConfluent VedarthConfluent marked this pull request as ready for review December 11, 2024 05:28
@VedarthConfluent VedarthConfluent requested a review from a team as a code owner December 11, 2024 05:28
@@ -23,8 +23,7 @@
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.not;
import static org.hamcrest.Matchers.nullValue;
import static org.junit.Assert.assertThrows;
import static org.junit.Assert.fail;
import static org.junit.Assert.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code style change, should be reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants