Skip to content

Commit 702c679

Browse files
committed
Disable checkpoint/restore unit tests for docker
Currently, nerdctl CI uses docker 28.0.4, while docker version 28.x has a known regression that breaks Checkpoint/Restore functionality. The issue is tracked in the moby/moby project as moby/moby#50750. Signed-off-by: ChengyuZhu6 <[email protected]>
1 parent 9f9e41f commit 702c679

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

cmd/nerdctl/checkpoint/checkpoint_create_linux_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"testing"
2222

2323
"github.com/containerd/nerdctl/mod/tigron/expect"
24+
"github.com/containerd/nerdctl/mod/tigron/require"
2425
"github.com/containerd/nerdctl/mod/tigron/test"
2526

2627
"github.com/containerd/nerdctl/v2/pkg/rootlessutil"
@@ -33,6 +34,9 @@ func TestCheckpointCreateErrors(t *testing.T) {
3334
t.Skip("test skipped for rootless containers")
3435
}
3536
testCase := nerdtest.Setup()
37+
// Docker version 28.x has a known regression that breaks Checkpoint/Restore functionality.
38+
// The issue is tracked in the moby/moby project as https://github.com/moby/moby/issues/50750.
39+
testCase.Require = require.Not(nerdtest.Docker)
3640
testCase.SubTests = []*test.Case{
3741
{
3842
Description: "too-few-arguments",
@@ -76,6 +80,9 @@ func TestCheckpointCreate(t *testing.T) {
7680
checkpointDir = "/dir/foo"
7781
)
7882
testCase := nerdtest.Setup()
83+
// Docker version 28.x has a known regression that breaks Checkpoint/Restore functionality.
84+
// The issue is tracked in the moby/moby project as https://github.com/moby/moby/issues/50750.
85+
testCase.Require = require.Not(nerdtest.Docker)
7986
testCase.SubTests = []*test.Case{
8087
{
8188
Description: "leave-running=true",

cmd/nerdctl/container/container_start_linux_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import (
2626
"gotest.tools/v3/assert"
2727

2828
"github.com/containerd/nerdctl/mod/tigron/expect"
29+
"github.com/containerd/nerdctl/mod/tigron/require"
2930
"github.com/containerd/nerdctl/mod/tigron/test"
3031
"github.com/containerd/nerdctl/mod/tigron/tig"
3132

@@ -86,6 +87,9 @@ func TestStartWithCheckpoint(t *testing.T) {
8687

8788
testCase := nerdtest.Setup()
8889

90+
// Docker version 28.x has a known regression that breaks Checkpoint/Restore functionality.
91+
// The issue is tracked in the moby/moby project as https://github.com/moby/moby/issues/50750.
92+
testCase.Require = require.Not(nerdtest.Docker)
8993
testCase.Setup = func(data test.Data, helpers test.Helpers) {
9094
helpers.Ensure("run", "-d", "--name", data.Identifier(), testutil.CommonImage, "sleep", "infinity")
9195
helpers.Ensure("checkpoint", "create", data.Identifier(), data.Identifier()+"-checkpoint")

0 commit comments

Comments
 (0)