CI: go lint action #3762
Closed
CI: go lint action #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
The new action will centralize go version so we stop having them peppered accross different files. It also provides simple "strategies" that cover all our cases (canary, latest-stable, old-stable). Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
ci-go-ling-action
branch
7 times, most recently
from
a02cd00 to
200f87f
Compare
apostasie
force-pushed
the
ci-go-ling-action
branch
from
200f87f to
5205602
Compare
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
ci-go-ling-action
branch
from
5205602 to
2e953b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3761
After consideration, suggesting we get rid of the action entirely, as it does not seem to be able to accommodate our usage:
golangci-lint run --verbose- which is ludicrous, and already provided by the makefile (and we should encourage the use of the same commands on the CI we expect people to run locally)Besides dropping the golangci action, this PR folds the imports ordering (previously separate task) into the lint-go action as well.
Note that one of the effects of this is that we loose the ability to cache lint results.
This is actually a good thing, as our github cache usage is currently a source of concern - and the cache does not provide any value for us (the linting process runs in seconds).
Finally, this is on top of #3760 which should go first.