Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish wasi-demo-app as a package #105

Open
codefromthecrypt opened this issue Apr 26, 2023 · 2 comments · May be fixed by #733
Open

Publish wasi-demo-app as a package #105

codefromthecrypt opened this issue Apr 26, 2023 · 2 comments · May be fixed by #733

Comments

@codefromthecrypt
Copy link

codefromthecrypt commented Apr 26, 2023

The image used for testing needs to be built from source https://github.com/containerd/runwasi/tree/main/crates/wasi-demo-app

It would be more convenient to access this as a package, especially as it clarifies what the ultimate OCI json are in use. e.g. to ghcr.io/containerd/runwasi/wasi-demo-app:latest

@rumpl
Copy link
Member

rumpl commented Apr 26, 2023

The source code is in this repo: https://github.com/containerd/runwasi/tree/main/crates/wasi-demo-app

I think that the readme should be updated because after a make load the image that's loaded has the name ghcr.io/containerd/runwasi/wasi-demo-app:latest

Note: the wasmtest image doesn't exist in Docker hub, docker.io/library is the default prefix added when an image name doesn't contain the registry name/namespace.

@codefromthecrypt
Copy link
Author

ok how about if I rename this to publish as a package? e.g. to ghcr.io/containerd/runwasi/wasi-demo-app:latest

@codefromthecrypt codefromthecrypt changed the title remove auth from wasmtest image Publish wasi-demo-app as a package Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants