-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FUSE Passthrough Support in Stargz-Snapshotter #1867
Comments
wswsmao
changed the title
Add Supporting FUSE Passthrough in Stargz-Snapshotter
Add FUSE Passthrough Support in Stargz-Snapshotter
Nov 19, 2024
The lattest commit is the implementation for FUSE Passthrough support in stargz-snapshotter |
SGTM. Could you open a PR? |
OK, this is pr |
ktock
added a commit
that referenced
this issue
Nov 21, 2024
Add FUSE Passthrough Support in Stargz-Snapshotter #1867
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
FUSE Passthrough has been introduced in the Linux kernel version 6.9. This feature has shown significant performance improvements, as detailed in the following articles:
Phoronix Article on FUSE Passthrough
Linux Kernel Commit
Additionally, the
go-fuse
package, which Stargz-Snapshotter depends on, has also added support for this passthrough feature:go-fuse Commit 1
go-fuse Commit 2
go-fuse Commit 3
When a user-defined file implements the
FilePassthroughFder
interface,go-fuse
will attempt to register the filefd
from the file with the kernel.I believe it would be beneficial for Stargz-Snapshotter to consider supporting this feature as well. Here’s a proposed implementation plan for FUSE passthrough:
Open
phase, attempt to pre-read the entire file instead of reading it in chunks.fd
of the cached file that has been written to local storage.FilePassthroughFder
interface innode.file
, allowing thefd
from step 2 to be registered with the kernel viago-fuse
.By following this approach, subsequent
Read
operations would not need to return to user space, andgo-fuse
would release the registered information when necessary.Thank you for considering this enhancement!
Best regards,
abush wang
The text was updated successfully, but these errors were encountered: