Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard remote snapshot labels? #326

Open
jonjohnsonjr opened this issue May 21, 2021 · 1 comment
Open

Standard remote snapshot labels? #326

jonjohnsonjr opened this issue May 21, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jonjohnsonjr
Copy link

jonjohnsonjr commented May 21, 2021

The labels here seem to serve the same purpose as these other than the TargetPrefetchSizeLabel.

Is there a reason for those three label keys to diverge? Could they be reused instead?

I was digging through nerdctl and came across this, which has some hard-coded logic for stargz. I'm wondering if it's possible to agree on some standard configuration for determining whether or not something is a remote snapshotter rather than looking specifically for stargz there... what do you think?

@ktock
Copy link
Member

ktock commented May 24, 2021

The labels here seem to serve the same purpose as these other than the TargetPrefetchSizeLabel.
Is there a reason for those three label keys to diverge? Could they be reused instead?

Yes, these label keys are diverse but have the same purpose. For tools other than CRI plugin (e.g. BuildKit, nerdctl, etc), default labels should be used.

I was digging through nerdctl and came across this, which has some hard-coded logic for stargz. I'm wondering if it's possible to agree on some standard configuration for determining whether or not something is a remote snapshotter rather than looking specifically for stargz there... what do you think?

Isn't referring snapshotter name enough? What's your use-case for this?

Stargz-related configurations are hard-coded to some of stargz-aware tools as of now and I agree that we should make them configurable (especially for making it easier to integrate other types of (non-stargz) remote snapshotters).

@ktock ktock added the enhancement New feature or request label Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants