Skip to content

Commit 9530cfa

Browse files
committed
Rename make tidy to make vendor in main Makefile
And also run the `go work sync` in the end of the main Makefile. Signed-off-by: Jan Kaluza <[email protected]>
1 parent 44ccaf7 commit 9530cfa

File tree

6 files changed

+14
-18
lines changed

6 files changed

+14
-18
lines changed

.cirrus.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,10 @@ storage_linux_testing: &linux_testing
7979
fingerprint_script: cat **/go.sum
8080
folder: $GOPATH/pkg/mod
8181
# Note the cache is populated the first time it is used with the given deps.
82-
# But because each task might not download all he same deps force make tidy
82+
# But because each task might not download all he same deps force make vendor
8383
# which downloads all deps for all modules. This is only run once when the
8484
# cache is created so it should not slow things down much.
85-
populate_script: make tidy
85+
populate_script: make vendor
8686

8787
# Separate scripts for separate outputs, makes debugging easier.
8888
setup_script: '${CIRRUS_WORKING_DIR}/${SCRIPT_BASE}/setup.sh |& ${_TIMESTAMP}'

.github/workflows/validate.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ jobs:
8787
# by default git-validation has some special github action handling but that seems broken.
8888
run: make .install.gitvalidation && git-validation -no-github
8989

90-
go-tidy:
90+
go-vendor:
9191
runs-on: ubuntu-24.04
9292
steps:
9393
- uses: actions/checkout@v5
@@ -96,7 +96,7 @@ jobs:
9696
go-version: 1.25.x
9797
# See comment on lint task
9898
cache-dependency-path: "**/go.sum"
99-
- name: tidy
100-
run: make tidy
99+
- name: vendor
100+
run: make vendor
101101
- name: check if tree is clean
102102
run: hack/tree_status.sh

CONTRIBUTING_GO.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ $ make vendor
4848

4949
If you are working in the [container-libs](https://github.com/containers/container-libs) monorepo use:
5050
```
51-
make tidy
51+
make vendor
5252
```
5353
This command syncs the dependency versions across all modules in the repo.
5454

Makefile

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,14 @@ lint: .install.golangci-lint
4949
@$(MAKE) -C image lint
5050
@$(MAKE) -C storage lint
5151

52-
.PHONY: tidy-in-container
53-
tidy-in-container:
54-
podman run --privileged --rm --env HOME=/root -v `pwd`:/src -w /src golang make tidy
52+
.PHONY: vendor-in-container
53+
vendor-in-container:
54+
podman run --privileged --rm --env HOME=/root -v `pwd`:/src -w /src golang make vendor
5555

56-
.PHONY: tidy
57-
tidy:
56+
.PHONY: vendor
57+
vendor:
5858
@$(MAKE) -C common tidy
5959
@$(MAKE) -C image tidy
6060
@$(MAKE) -C storage tidy
61+
$(GO) work vendor
62+
$(GO) work sync

hack/tree_status.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/usr/bin/env bash
22
set -e
33

4-
SUGGESTION="${SUGGESTION:-run \"make tidy\" and commit all changes.}"
4+
SUGGESTION="${SUGGESTION:-run \"make vendor\" and commit all changes.}"
55

66
STATUS=$(git status --porcelain)
77
if [[ -z $STATUS ]]

vendor/modules.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ github.com/containerd/log
5252
# github.com/containerd/platforms v0.2.1
5353
## explicit; go 1.20
5454
github.com/containerd/platforms
55-
# github.com/containerd/stargz-snapshotter/estargz v0.17.0
56-
## explicit; go 1.24.0
5755
# github.com/containerd/stargz-snapshotter/estargz v0.18.0
5856
## explicit; go 1.24.0
5957
github.com/containerd/stargz-snapshotter/estargz
@@ -249,8 +247,6 @@ github.com/jinzhu/copier
249247
# github.com/json-iterator/go v1.1.12
250248
## explicit; go 1.12
251249
github.com/json-iterator/go
252-
# github.com/klauspost/compress v1.18.0
253-
## explicit; go 1.23
254250
# github.com/klauspost/compress v1.18.1
255251
## explicit; go 1.23
256252
github.com/klauspost/compress
@@ -508,8 +504,6 @@ github.com/ulikunitz/xz
508504
github.com/ulikunitz/xz/internal/hash
509505
github.com/ulikunitz/xz/internal/xlog
510506
github.com/ulikunitz/xz/lzma
511-
# github.com/vbatts/tar-split v0.12.1
512-
## explicit; go 1.17
513507
# github.com/vbatts/tar-split v0.12.2
514508
## explicit; go 1.17
515509
github.com/vbatts/tar-split/archive/tar

0 commit comments

Comments
 (0)