Skip to content

Commit cd4b3dc

Browse files
committed
Document that we assume exact digest matching in c/common/pkg/manifests
This is all fine and internally consistent, but eventually that assumption will probably require changes in the Podman caller of c/common/libimage.ManifestList.RemoveInstance. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
1 parent 01833ef commit cd4b3dc

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

common/pkg/manifests/manifests.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ import (
1818

1919
// List is a generic interface for manipulating a manifest list or an image
2020
// index.
21+
//
22+
// Note: the instanceDigest values used for lookups/removals must exactly match the digests in the manifest list, in particular use the algorithm used there.
2123
type List interface {
2224
AddInstance(manifestDigest digest.Digest, manifestSize int64, manifestType, os, architecture, osVersion string, osFeatures []string, variant string, features []string, annotations []string) error
2325
Remove(instanceDigest digest.Digest) error

0 commit comments

Comments
 (0)