address review comments

Signed-off-by: iamsudip <[email protected]>

Author: iamsudip

README.md

@@ -261,7 +261,7 @@ The following sets of tools are available (all on by default):
   - `name` (`string`) **(required)** - Name of the Pod to get the logs from
   - `namespace` (`string`) - Namespace to get the Pod logs from
   - `previous` (`boolean`) - Return previous terminated container logs (Optional)
-  - `tailLines` (`number`) - Number of lines to retrieve from the end of the logs (Optional, default: 256)
+  - `tail` (`number`) - Number of lines to retrieve from the end of the logs (Optional, default: 100)
 
 - **pods_run** - Run a Kubernetes Pod in the current or provided namespace with the provided container image and optional name
   - `image` (`string`) **(required)** - Container Image to run in the Pod

pkg/kubernetes/pods.go

@@ -17,10 +17,14 @@ import (
 	"k8s.io/client-go/tools/remotecommand"
 	"k8s.io/metrics/pkg/apis/metrics"
 	metricsv1beta1api "k8s.io/metrics/pkg/apis/metrics/v1beta1"
+	"k8s.io/utils/ptr"
 
 	"github.com/containers/kubernetes-mcp-server/pkg/version"
 )
 
+// Default number of lines to retrieve from the end of the logs
+const DefaultTailLines = int64(100)
+
 type PodsTopOptions struct {
 	metav1.ListOptions
 	AllNamespaces bool
@@ -107,9 +111,8 @@ func (k *Kubernetes) PodsLog(ctx context.Context, namespace, name, container str
 	if tailLines > 0 {
 		logOptions.TailLines = &tailLines
 	} else {
-		// Default to 256 lines when not specified
-		defaultLines := int64(256)
-		logOptions.TailLines = &defaultLines
+		// Default to DefaultTailLines lines when not specified
+		logOptions.TailLines = ptr.To(DefaultTailLines)
 	}
 
 	req := pods.GetLogs(name, logOptions)

pkg/mcp/pods_test.go

@@ -757,13 +757,13 @@ func TestPodsLog(t *testing.T) {
 			}
 		})
 
-		// Test with tailLines parameter
+		// Test with tail parameter
 		podsTailLines, err := c.callTool("pods_log", map[string]interface{}{
 			"namespace": "ns-1",
 			"name":      "a-pod-in-ns-1",
-			"tailLines": 100,
+			"tail":      50,
 		})
-		t.Run("pods_log with tailLines=100 returns pod log", func(t *testing.T) {
+		t.Run("pods_log with tail=50 returns pod log", func(t *testing.T) {
 			if err != nil {
 				t.Fatalf("call tool failed %v", err)
 				return
@@ -774,18 +774,18 @@ func TestPodsLog(t *testing.T) {
 			}
 		})
 
-		// Test with invalid tailLines parameter
+		// Test with invalid tail parameter
 		podsInvalidTailLines, _ := c.callTool("pods_log", map[string]interface{}{
 			"namespace": "ns-1",
 			"name":      "a-pod-in-ns-1",
-			"tailLines": "invalid",
+			"tail":      "invalid",
 		})
-		t.Run("pods_log with invalid tailLines returns error", func(t *testing.T) {
+		t.Run("pods_log with invalid tail returns error", func(t *testing.T) {
 			if !podsInvalidTailLines.IsError {
 				t.Fatalf("call tool should fail")
 				return
 			}
-			expectedErrorMsg := "failed to parse tailLines parameter: expected integer"
+			expectedErrorMsg := "failed to parse tail parameter: expected integer"
 			if errMsg := podsInvalidTailLines.Content[0].(mcp.TextContent).Text; !strings.Contains(errMsg, expectedErrorMsg) {
 				t.Fatalf("unexpected error message, expected to contain '%s', got '%s'", expectedErrorMsg, errMsg)
 				return

pkg/toolsets/core/pods.go

@@ -201,10 +201,10 @@ func initPods() []api.ServerTool {
 						Type:        "string",
 						Description: "Name of the Pod container to get the logs from (Optional)",
 					},
-					"tailLines": {
+					"tail": {
 						Type:        "integer",
-						Description: "Number of lines to retrieve from the end of the logs (Optional, default: 256)",
-						Default:     api.ToRawMessage(int64(256)),
+						Description: "Number of lines to retrieve from the end of the logs (Optional, default: 100)",
+						Default:     api.ToRawMessage(kubernetes.DefaultTailLines),
 						Minimum:     ptr.To(float64(0)),
 					},
 					"previous": {
@@ -403,7 +403,7 @@ func podsLog(params api.ToolHandlerParams) (*api.ToolCallResult, error) {
 		previousBool = previous.(bool)
 	}
 	// Extract tailLines parameter
-	tailLines := params.GetArguments()["tailLines"]
+	tailLines := params.GetArguments()["tail"]
 	var tailLinesInt int64
 	if tailLines != nil {
 		// Convert to int64 - safely handle both float64 (JSON number) and int types
@@ -415,7 +415,7 @@ func podsLog(params api.ToolHandlerParams) (*api.ToolCallResult, error) {
 		case int64:
 			tailLinesInt = v
 		default:
-			return api.NewToolCallResult("", fmt.Errorf("failed to parse tailLines parameter: expected integer, got %T", tailLines)), nil
+			return api.NewToolCallResult("", fmt.Errorf("failed to parse tail parameter: expected integer, got %T", tailLines)), nil
 		}
 	}