Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balloons: enable ignoring the error where a pod has been annotated with a non-existing balloon type #216

Open
askervin opened this issue Dec 22, 2023 · 0 comments

Comments

@askervin
Copy link
Collaborator

askervin commented Dec 22, 2023

Description

Under some scenarios the balloon type in the annotation can be only a preference rather than a strict requirement. If a preferred balloon type does not exist, he pod/container should be handled as if there would not be balloon annotation at all. That is, chooseBalloonDef() based on namespaces in balloon types or assigning the pod to a default balloon.

Potential ways to introduce such behavior include:

  • use an annotation that specifically means preference instead of a requirement
  • add an option to ignore the non-existing balloon type error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant