Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review potential upstream problems #2

Open
jmatsushita opened this issue Sep 18, 2017 · 3 comments
Open

Review potential upstream problems #2

jmatsushita opened this issue Sep 18, 2017 · 3 comments

Comments

@jmatsushita
Copy link
Member

Hi @joncamfield

The migration script now displays missing transclusion links in the CI log.

Missing transclusion destination in methods/assessment_plan.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/assessment_plan/quote.md
Missing transclusion destination in methods/assessment_plan.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/assessment_plan/summary.md
Missing transclusion destination in methods/assessment_plan.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/assessment_plan/purpose.md
Missing transclusion destination in methods/assessment_plan.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/assessment_plan/preparation.md
Missing transclusion destination in methods/assessment_plan.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/assessment_plan/materials_needed.md
Missing transclusion destination in methods/assessment_plan.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/assessment_plan/approach.md
Missing transclusion destination in methods/assessment_plan.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/assessment_plan/output.md
Missing transclusion destination in methods/assessment_plan.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/assessment_plan/operational_security.md
Missing transclusion destination in methods/assessment_plan.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/assessment_plan/reporting.md
Missing transclusion destination in methods/assessment_plan.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/assessment_plan/summary.md
Missing transclusion destination in methods/assessment_plan.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/assessment_plan/approach.md
Missing transclusion destination in methods/capacity_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/capacity_assessment/operational_security.md
Missing transclusion destination in methods/capacity_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/references/capacity_assessment.md
Missing transclusion destination in methods/device_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/device_assessment/quote.md
Missing transclusion destination in methods/device_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/device_assessment/summary.md
Missing transclusion destination in methods/device_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/device_assessment/purpose.md
Missing transclusion destination in methods/device_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/device_assessment/baseline_skills.md
Missing transclusion destination in methods/device_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/device_assessment/preparation.md
Missing transclusion destination in methods/device_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/device_assessment/materials_needed.md
Missing transclusion destination in methods/device_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/device_assessment/approach.md
Missing transclusion destination in methods/device_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/device_assessment/output.md
Missing transclusion destination in methods/device_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/device_assessment/operational_security.md
Missing transclusion destination in methods/device_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/device_assessment/reporting.md
Missing transclusion destination in methods/device_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/device_assessment/examples/device_checklist/index.md
Missing transclusion destination in methods/follow_up.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/follow_up/output.md
Missing transclusion destination in methods/follow_up.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/follow_up/preparation.md
Missing transclusion destination in methods/follow_up.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/references/follow_up_overview.md
Missing transclusion destination in methods/interviews.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/interviews/quote.md
Missing transclusion destination in methods/interviews.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/interviews/summary.md
Missing transclusion destination in methods/interviews.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/interviews/purpose.md
Missing transclusion destination in methods/interviews.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/interviews/baseline_skills.md
Missing transclusion destination in methods/interviews.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/interviews/preparation.md
Missing transclusion destination in methods/interviews.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/interviews/materials_needed.md
Missing transclusion destination in methods/interviews.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/interviews/approach.md
Missing transclusion destination in methods/interviews.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/interviews/output.md
Missing transclusion destination in methods/interviews.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/interviews/operational_security.md
Missing transclusion destination in methods/interviews.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/interviews/reporting.md
Missing transclusion destination in methods/interviews.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/interviews/summary.md
Missing transclusion destination in methods/network_assessment.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/network_access/summary.md
Missing transclusion destination in methods/network_assessment.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/network_access/summary.md
Missing transclusion destination in methods/network_discovery.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/network_discovery/summary.md
Missing transclusion destination in methods/network_discovery.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/network_discovery/purpose.md
Missing transclusion destination in methods/network_discovery.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/network_discovery/guiding_questions.md
Missing transclusion destination in methods/network_discovery.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/network_discovery/approaches.md
Missing transclusion destination in methods/network_discovery.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/network_discovery/output.md
Missing transclusion destination in methods/network_discovery.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/network_discovery/operational_security.md
Missing transclusion destination in methods/network_discovery.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/network_discovery/preparation.md
Missing transclusion destination in methods/network_discovery.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/network_discovery/summary.md
Missing transclusion destination in methods/network_discovery.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/network_discovery/purpose.md
Missing transclusion destination in methods/network_discovery.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/network_discovery/guiding_questions.md
Missing transclusion destination in methods/network_discovery.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/network_discovery/approaches.md
Missing transclusion destination in methods/operational_security.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/references/operational_security.md
Missing transclusion destination in methods/operational_security.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/physical_assessment/summary.md
Missing transclusion destination in methods/operational_security.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/physical_assessment/purpose.md
Missing transclusion destination in methods/operational_security.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/physical_assessment/guiding_questions.md
Missing transclusion destination in methods/operational_security.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/physical_assessment/approaches.md
Missing transclusion destination in methods/reconnaissance.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/reconnaisance/preparation.md
Missing transclusion destination in methods/report_creation.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/report_creation/baseline_skills.md
Missing transclusion destination in methods/report_creation.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/report_creation/preparation.md
Missing transclusion destination in methods/report_creation.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/report_creation/materials_needed.md
Missing transclusion destination in methods/report_creation.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/reference/report_writing.md
Missing transclusion destination in methods/report_creation.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/reference/report_supporting_references.md
Missing transclusion destination in methods/report_creation.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/reference/financial_barriers.md
Missing transclusion destination in methods/resource_identification.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/resource_identification/quote.md
Missing transclusion destination in methods/resource_identification.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/resource_identification/summary.md
Missing transclusion destination in methods/resource_identification.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/resource_identification/purpose.md
Missing transclusion destination in methods/resource_identification.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/resource_identification/baseline_skills.md
Missing transclusion destination in methods/resource_identification.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/resource_identification/preparation.md
Missing transclusion destination in methods/resource_identification.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/resource_identification/materials_needed.md
Missing transclusion destination in methods/resource_identification.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/resource_identification/approach.md
Missing transclusion destination in methods/resource_identification.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/resource_identification/output.md
Missing transclusion destination in methods/resource_identification.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/resource_identification/operational_security.md
Missing transclusion destination in methods/resource_identification.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/resource_identification/reporting.md
Missing transclusion destination in methods/resource_identification.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/resource_identification/summary.md
Missing transclusion destination in methods/resource_identification.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/resource_identification/approach.md
Missing transclusion destination in methods/risk_assessment.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/risk_modeling/summary.md
Missing transclusion destination in methods/risk_assessment.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/risk_modeling/approach.md
Missing transclusion destination in methods/roadmap_development.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/roadmap_development/baseline_skills.md
Missing transclusion destination in methods/roadmap_development.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/roadmap_development/preparation.md
Missing transclusion destination in methods/roadmap_development.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/roadmap_development/materials_needed.md
Missing transclusion destination in methods/roadmap_development.guide.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/reporting/roadmap_development/approach.md
Missing transclusion destination in methods/training.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/training/summary.md
Missing transclusion destination in methods/training.overview.md: /home/travis/build/contentascode/safetag/workspace/SAFETAG/en/methods/guides/training/approach.md
Unknown field ../traffic_analysis/recommendations in file exercises/day_in_the_life/index.md
Unknown field password_survey in file exercises/password_security/index.md
Unknown field base_line_skills in file exercises/un_addressed_concerns/index.md
Unknown field considerations in file exercises/un_addressed_concerns/index.md
Unknown field output in file exercises/un_addressed_concerns/index.md
Unknown field resources in file exercises/un_addressed_concerns/index.md

I think that most of these are due to a template method being copied but with missing sections. Could you have a look as well and let me know and I can submit a PR to clean this up so we only have errors reports about real problems.

day_in_the_life and password_security seem to have a specific structure, and un_addressed_concerns also seems to be a special case, let me know how to handle these.

Cheers,

Jun

@jmatsushita
Copy link
Member Author

The previous version of the migration script didn't check exercises so the list is longer now.

@joncamfield
Copy link

joncamfield commented Sep 20, 2017

I have cleaned those three exercises in my fork at https://github.com/joncamfield/SAFETAG

    joncamfield stadardizing day in the life exercise per contentascode/metalsmith-mi… …     ad0a551
    joncamfield split password security into 2 exercises for clartiy     f566c01
    joncamfield removed non-standard un-addressed concerns exercise into reporting me… …     f211c15

And while some of the errors above are certainly due to missing files expected by index templates, some should not be. I will have to dig into those a bit further.

@joncamfield
Copy link

the fd80c49 commit in joncamfield/safetag removes a lot of the "dead" files that have been merged, removed, or remapped elsewhere and should dramatically reduce those errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants