Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit ranged marker on progress bar #60

Open
vanlinha3k35pbc opened this issue Feb 28, 2020 · 1 comment
Open

Edit ranged marker on progress bar #60

vanlinha3k35pbc opened this issue Feb 28, 2020 · 1 comment

Comments

@vanlinha3k35pbc
Copy link

vanlinha3k35pbc commented Feb 28, 2020

Description

I want to add ranged marker on progress bar which has:

  1. Start and end point dragable (in case editing marker) on progress bar when clicked.
  2. Action trigger after dragging start/end point
  3. Color can be customize

Question

a. It is possible to having 1,2 when adding new annotation. But I can not edit annotation. Is there something I miss out?
b. Is 3 possible (eg. adding custom class for annotation)

Additional Information

versions

    "@contently/videojs-annotation-comments": "^2.0.1",
    "imports-loader": "^0.8.0",
    "jquery": "^3.4.1",
    "video.js": "^7.6.6"

browsers

Currently using Chrome, also experienced on Firefox

OS

Windows 10

Demo repo

https://github.com/vanlinha3k35pbc/progress-bar-marker-demo

@vanlinha3k35pbc vanlinha3k35pbc changed the title Ranged marker on progress bar Edit ranged marker on progress bar Feb 28, 2020
@jackpope
Copy link
Contributor

jackpope commented Apr 3, 2020

Hi @vanlinha3k35pbc

There currently is no support for editing annotations. The use-cases that have come up so far are solved by deleting and re-creating annotations that may have been added incorrectly. Editing/updating could be useful to some though -- would be great to see a PR for the support 😄

For global customization, you can add styling to the build in classes: .vac-marker, .vac-marker-draggable. Is the idea to add a custom class per marker? How would you expect that you be configured or the data passed in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants