Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practices on workflow approval #14

Open
IAlibay opened this issue Sep 21, 2022 · 3 comments
Open

Best practices on workflow approval #14

IAlibay opened this issue Sep 21, 2022 · 3 comments
Labels
contributor workflow Issues related to the contribution workflow to this repo documentation Improvements or additions to documentation related to building the handbook itself

Comments

@IAlibay
Copy link

IAlibay commented Sep 21, 2022

Due to security reasons github by default enforces approval to run workflows for first time contributors.

This is in many cases unavoidable, however we struggle with the fact that this can act as an additional barrier to new contributors who may not understand the various fine details of how actions can be abused.

I'm not sure if we're the only ones seeing this - if it's more widespread it may be good to have some kind of information on what interaction limits exist, which flavour of the settings would be advised, and what to consider when using a given interaction limit?

@asmeurer
Copy link

Many people aren't aware that this setting can be changed to "require approval for first time contributors who are new to GitHub". It has to be done per-repository.

@IAlibay
Copy link
Author

IAlibay commented Sep 21, 2022

I think some interaction limits can now be set at the organization level? https://docs.github.com/en/communities/moderating-comments-and-conversations/limiting-interactions-in-your-organization

Note / edit: I say think because I stumbled upon this about a week ago and I've yet to read the thing properly 😓

@melissawm melissawm added the contributor workflow Issues related to the contribution workflow to this repo label Sep 21, 2022
@asmeurer
Copy link

asmeurer commented Sep 21, 2022

I think that's more about making things more limited than the default, e.g., for when your community gets unexpected attention from many outside trolls and other unhelpful people, whereas for this you'd want to lessen the default limits because they introduce a barrier to new contributors.

@noatamir noatamir added the documentation Improvements or additions to documentation related to building the handbook itself label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor workflow Issues related to the contribution workflow to this repo documentation Improvements or additions to documentation related to building the handbook itself
Projects
None yet
Development

No branches or pull requests

4 participants