Linting

Author: foarsitter

.github/ISSUE_TEMPLATE/bug.md

@@ -13,6 +13,7 @@ labels: bug
 <!-- To assist you best, please include commands that you've run, options you've selected and any relevant logs -->
 
 - Host system configuration:
+
   - Version of cookiecutter CLI (get it with `cookiecutter --version`):
   - OS name and version:
 

hooks/post_gen_project.py

@@ -203,7 +203,7 @@ def remove_prettier_pre_commit():
 
 def remove_repo_from_pre_commit_config(repo_to_remove: str):
     pre_commit_config = Path(".pre-commit-config.yaml")
-    content = pre_commit_config.read_text().splitlines(True)
+    content = pre_commit_config.read_text().splitlines(keepends=True)
 
     removing = False
     new_lines = []
@@ -517,7 +517,7 @@ def setup_dependencies():
     if "{{ cookiecutter.use_docker }}".lower() == "y":
         # Build the Docker service using Docker Compose
         try:
-            subprocess.run(["docker", "compose", "-f", "docker-compose.local.yml", "build", "django"], check=True)
+            subprocess.run(["docker", "compose", "-f", "docker-compose.local.yml", "build", "django"], check=True)  # noqa: S607
         except subprocess.CalledProcessError as e:
             print(f"Error building Docker service: {e}", file=sys.stderr)
             sys.exit(1)
@@ -530,23 +530,23 @@ def setup_dependencies():
 
     # Install production dependencies
     try:
-        subprocess.run(uv_cmd + ["add", "--no-sync", "-r", "requirements/production.txt"], check=True)
+        subprocess.run([*uv_cmd, "add", "--no-sync", "-r", "requirements/production.txt"], check=True)  # noqa: S603
     except subprocess.CalledProcessError as e:
         print(f"Error installing production dependencies: {e}", file=sys.stderr)
         sys.exit(1)
 
     # Install local (development) dependencies
     try:
-        subprocess.run(uv_cmd + ["add", "--no-sync", "--dev", "-r", "requirements/local.txt"], check=True)
+        subprocess.run([*uv_cmd, "add", "--no-sync", "--dev", "-r", "requirements/local.txt"], check=True)  # noqa: S603
     except subprocess.CalledProcessError as e:
         print(f"Error installing local dependencies: {e}", file=sys.stderr)
         sys.exit(1)
 
     # Remove the requirements directory
-    if os.path.exists("requirements"):
+    if os.path.exists("requirements"):  # noqa: PTH110
         try:
             shutil.rmtree("requirements")
-        except Exception as e:
+        except Exception as e:  # noqa: BLE001
             print(f"Error removing 'requirements' folder: {e}", file=sys.stderr)
             sys.exit(1)
 

tests/test_cookiecutter_generation.py

@@ -157,8 +157,7 @@ def build_files_list(base_path: Path):
     for dirpath, subdirs, files in base_path.walk():
         subdirs[:] = [d for d in subdirs if d not in excluded_dirs]
 
-        for file_path in files:
-            f.append(dirpath / file_path)
+        f.extend(dirpath / file_path for file_path in files)
     return f