Improve type hints for UserSerializer
#4429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I recently came across the fact that
djangorestframework-stubs
supports using generics in model serializers, which has the effect of improving type hints:self.instance
is known to be an instance of the model instead ofAny
.It would be nice to show that feature in the only serializer that we include, the
UserSerializer
.Checklist:
Rationale
Improve discoverability of a nice feature, improve type checking, improve auto-completion.