-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloning the Repository inside a Container from GitHub #5310
Comments
Is it a game that you are playing that we need to find the error ourselfs? |
Define "slow" please. Is it slow just the first time or every time? I don't use devcontainers myself, but AFAIU, it uses the main Django image from docker compose, so yeah, it takes a few minutes. The whole config is under We're happy to accept any performance improvements via pull request, if you can provide some, but it's most likely due to Docker being slow. |
What kind of reply is that supposed to be? I'm here and try to find guidance and thats how you response to people?
On windows there is a massive performance difference between cloning a repository inside a devcontainer or mounting it. The difference becomes exponentially bigger the more files there are, in Django projects, there are quite a few, especially due to the venv and node Modules. In my personal project I've originally created based off of this repository, slow means running simple tests takes about ~30 seconds, which is very frustrating. I think this is something that must be fixed on your side. I'm not saying it is an error you're having in the code, but the Dockerfile most likely needs some finetuning to work with this devcontainer feature. I'm just not sure what it could be and was hoping there is someone here that is more experienced with it. |
It is my salty response to your Are you submitting a bug report? Then describe the bug and provide details. Show other people you did your work thoroughly. Now you are writing about an error without telling us the error you got. If you are seeking guidance, try to open a discussion or even better open a post on stackoverflow. |
Looking at the docker logs, there are quite a few things failing:
Not sure what's relevant to be honest...
That's possible, yes. As I said, we're happy to receive any perf improvements.
Fair enough. I don't have much experience with it, but you can perhaps look at what was done in the past:
cc @masavini who initially contributed the feature |
What happened?
My ideal development environment is inside a devcontainer, where the volume is cloned inside, rather than mounted (for performance reasons). Unfortunately I get an error, when I try to clone the repository inside the devcontainer.
What should've happened instead?
The repository should be cloned inside the devcontainer successfully.
Additional details
I've setup a repository to test with here, it's a fresh setup with cookiecutter.
Creating the devcontainer and mounting the volume works just fine - but is very slow.
Host system configuration:
cookiecutter --version
): 2024.08.19python3 -V
: 3.12docker --version
: Docker version 20.10.20docker compose --version
: Docker Compose version v2.28.1-desktop.1Options selected and/or replay file:
On Linux and macOS:
cat ${HOME}/.cookiecutter_replay/cookiecutter-django.json
(Please, take care to remove sensitive information): mostly defaults
The text was updated successfully, but these errors were encountered: