Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"S" keyboard command not working to save results #42

Open
rtfraser86 opened this issue Apr 22, 2024 · 12 comments
Open

"S" keyboard command not working to save results #42

rtfraser86 opened this issue Apr 22, 2024 · 12 comments

Comments

@rtfraser86
Copy link

Cannot get the S button to work as the keyboard command to save results. Have it working on another PC. Installed exactly the same. Running QGIS 3.36.1.

@Fanchengyan
Copy link
Collaborator

Hi @rtfraser86 ,

Sorry for the late reply. This bug is likely not related to the version of QGIS. Shortcuts only work when the plugin is in focus. Therefore, before using any shortcuts, you can click on the plugin to ensure it is active. If this approach does not resolve the issue, consider directly downloading the latest code from the main branch and replacing the existing code.

@rtfraser86
Copy link
Author

Hi @Fanchengyan - I can get ctrl+z to work, just not S. Plugin is in focus. Using QGIS 3.36.0 and .1 (2 different computers)

@Fanchengyan
Copy link
Collaborator

Hi @rtfraser86 ,

Which version of Geo-SAM are you currently using? The latest code from the main branch should work properly.

截图_20240507113955

@Segmentoholic
Copy link

Segmentoholic commented Aug 26, 2024

Hello,

I have the same problem as described by @rtfraser86.

All shortcuts work fine, apart from the "S"-Saving-Shortcut. Tried it out on different versions of QGIS (3.36 and 3.38) and Geo-SAM, including the latest from the main branch.

Has a solution been found for this problem?

Thank you for your help in advance.

P.S.: Following the plugin window in QGIS, where you can activate/deactivate all plugins, Geo-SAM's version always keeps being 1.0, even when 1.1.1 or 1.3 is installed. Is this correct (maybe it's a hint to solve the problem)?

Thank you

@Fanchengyan
Copy link
Collaborator

Is the new plugin like this? The latest version of the toolbar only has one row.

iShot_2024-08-27_16 25 27

@Segmentoholic
Copy link

Hi @Fanchengyan,

thank you for your fast reply.

Yes, it looks exactly the same.

@Fanchengyan
Copy link
Collaborator

Hi @Segmentoholic

What conditions trigger the issue? I can't pin the problem as it runs normally on Windows/Mac/Linux. Does the issue still occur after creating a new shapefile following SAM Output Layer or File?

@Segmentoholic
Copy link

Hi @Fanchengyan,

conditions are: Win 11, QGIS 3.38, Geo-SAM 1.3.

I'm saving the generated segmentation results as polygons into a geopackage layer. In this set-up, "S" shortcut is not working.
Saving via clicking the "Save" button works fine. But when doing so, you always have to click on your map/tif/layer in the main window first before you are able to move it again and continue segmenatation. So with the "S" shortcut, segmentation work would be even faster.

I also tried to save segmentation results into shp layer and the self-created "polygon_sam" layer, but there same problem is occuring.

Thank you in advance.

@Fanchengyan
Copy link
Collaborator

Hi @Segmentoholic

In fact, we only designed it to be stored in shapefile format. When we tried to expand to other formats, we found that many operations supported by shapefile format were not supported in QGIS. We haven't done in-depth research on geopackage, so I suggest you save it in shapefile format to complete the segmentation, and then convert it to geopackage format.

@Segmentoholic
Copy link

Hi @Fanchengyan,

thank you for the insight, but unfortunately in shapefile format the problem persists.

Maybe I'm doing something wrong, but when all other shortcuts are working I guess "S"-Shortcut should do as well (and plugin should be in focus then). But saving shortcut is still not running, unfortunately.

Thank you for your help in advance.

@Segmentoholic
Copy link

update:

Got it into work with geopackage on a different, but almost equal PC. Only difference was QGIS version (3.34 instead of 3.38).
But trying it out with 3.34 on the "problem PC" still leads to disfunction of saving shortcut. 🤷‍♂️

@Segmentoholic
Copy link

solved:

Snapping Toolbar captured "S" before Geo-SAM could.
Disabling this toolbar solved the problem.

Thank you again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants