Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New delivery; Show price before finishing #1793

Closed
Tracked by #30
, #35
...
vladimir-8 opened this issue May 24, 2024 · 3 comments · Fixed by #1922
Closed
Tracked by #30
, #35
...

New delivery; Show price before finishing #1793

vladimir-8 opened this issue May 24, 2024 · 3 comments · Fixed by #1922
Assignees
@Pierre-LHOSTE
Labels
Local Commerce Purchase Process

Comments

@vladimir-8
Copy link
Contributor

vladimir-8 commented May 24, 2024 •
edited
Loading

Show only Total price for now, later on: #1885
@vladimir-8 vladimir-8 mentioned this issue May 24, 2024
Open
74 tasks
@vladimir-8 vladimir-8 changed the title New delivery; Show price before finishing + price details New delivery; Show price before finishing + price details [API changes required] May 24, 2024
Open
49 tasks
@alexsegura
Copy link
Member

alexsegura commented Sep 23, 2024 •
edited
Loading

The /api/retail_prices/calculate endpoint can already be used for this.

We just need to make sure to send the store property in the payload, like in this example

@vladimir-8 vladimir-8 changed the title New delivery; Show price before finishing + price details [API changes required] New delivery; Show price before finishing Sep 30, 2024
@vladimir-8
Copy link
Contributor Author

@Pierre-LHOSTE to make it consistent with the current web implementation, we should not allow a store owner to proceed if a price can not be calculated. We will work on it in coopcycle/coopcycle-web#4557

Image

@Atala
Copy link
Member

Atala commented Nov 18, 2024

add an error message saying "price could not be calculated; please contact us to manage the issue."

@Pierre-LHOSTE Pierre-LHOSTE mentioned this issue Nov 21, 2024
Merged
@Pierre-LHOSTE Pierre-LHOSTE linked a pull request Dec 11, 2024 that will close this issue
Add error message if price calculation fails #1922
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pierre-LHOSTE Pierre-LHOSTE

Labels
Local Commerce Purchase Process
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add error message if price calculation fails coopcycle/coopcycle-app
5 participants
@alexsegura @Atala @vladimir-8 @Paul-Eraman-CoopCycle @Pierre-LHOSTE