Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coqpit.save_json() writes an empty file even if it failed #39

Open
georgettica opened this issue Apr 19, 2023 · 1 comment
Open

Coqpit.save_json() writes an empty file even if it failed #39

georgettica opened this issue Apr 19, 2023 · 1 comment

Comments

@georgettica
Copy link

if the dataclass has a missing field and it was not provided to, the json location will have an empty file there which will later cause a json loaded to crash on it.
@erogol
Copy link
Member

erogol commented Jun 8, 2023

do you have something to reproduce the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erogol @georgettica