We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The tests for the non-custodial escrow example program are now out of date against the latest @solana/spl-token package.
@solana/spl-token
Also, there is a superficial mistake here https://github.com/coral-xyz/anchor-by-example/blob/master/programs/non-custodial-escrow/tests/non-custodial-escrow.ts#L112 where the test should instead use program.methods.accept() per the anchor rust program design.
program.methods.accept()
Could I submit a PR to fix this example? The page here would also need to be updated. https://examples.anchor-lang.com/docs/non-custodial-escrow Asking in advance before I make the PR :)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The tests for the non-custodial escrow example program are now out of date against the latest
@solana/spl-token
package.Also, there is a superficial mistake here https://github.com/coral-xyz/anchor-by-example/blob/master/programs/non-custodial-escrow/tests/non-custodial-escrow.ts#L112 where the test should instead use
program.methods.accept()
per the anchor rust program design.Could I submit a PR to fix this example? The page here would also need to be updated. https://examples.anchor-lang.com/docs/non-custodial-escrow
Asking in advance before I make the PR :)
The text was updated successfully, but these errors were encountered: