fix: separate PDA handling for multiple token programs in escrow tests#3269
Closed
techvoyagerX wants to merge 1 commit intosolana-foundation:masterfrom
Closed
fix: separate PDA handling for multiple token programs in escrow tests#3269techvoyagerX wants to merge 1 commit intosolana-foundation:masterfrom
techvoyagerX wants to merge 1 commit intosolana-foundation:masterfrom
Conversation
|
@techvoyagerX is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
jamie-osec
added
javascript
Collaborator
|
If this is still an issue, can you please add a test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the same PDA was being used for both TOKEN_PROGRAM_ID and TOKEN_2022_PROGRAM_ID during escrow tests, which could cause conflicts. The fix involves deriving separate PDAs for each token program, ensuring that the right authority is used based on the token program involved. This resolves potential ownership conflicts when interacting with the escrow state across multiple token programs.