fix PR comments

Author: mmat11

bpf/common/trace_common.h

@@ -98,10 +98,6 @@ static __always_inline unsigned char *bpf_strstr_tp_loop__legacy(unsigned char *
 
     const u16 k_besteffort_max_loops = 400; // Limited best-effort search to stay within insns limit
     for (u16 i = 0; i + TRACE_PARENT_HEADER_LEN < k_besteffort_max_loops; i++) {
-        if (i != 0 && buf[i - 1] != '\n') {
-            continue;
-        }
-
         if (is_traceparent(&buf[i])) {
             return &buf[i];
         }

bpf/generictracer/protocol_http.h

@@ -493,14 +493,14 @@ static __always_inline int __obi_protocol_http(unsigned char *(*tp_loop_fn)(unsi
 
 // k_tail_protocol_http
 SEC("kprobe/http")
-static int obi_protocol_http(void *ctx) {
+int obi_protocol_http(void *ctx) {
     (void)ctx;
     return __obi_protocol_http(bpf_strstr_tp_loop);
 }
 
 // k_tail_protocol_http
 SEC("kprobe/http")
-static int obi_protocol_http_legacy(void *ctx) {
+int obi_protocol_http_legacy(void *ctx) {
     (void)ctx;
     return __obi_protocol_http(bpf_strstr_tp_loop__legacy);
 }

pkg/components/ebpf/common/common.go

@@ -306,7 +306,6 @@ func SupportsContextPropagationWithProbe(log *slog.Logger) bool {
 }
 
 func SupportsEBPFLoops(log *slog.Logger, overrideKernelVersion bool) bool {
-	// TODO(matt): probe for BPF_FUNC_loop instead of relying on kernel version?
 	if overrideKernelVersion {
 		log.Debug("Skipping kernel version check for bpf_loop functionality: user supplied confirmation of support")
 		return true

pkg/components/ebpf/instrumenter.go

@@ -20,7 +20,7 @@ import (
 
 	"github.com/cilium/ebpf"
 	"github.com/cilium/ebpf/link"
-	"github.com/containers/common/pkg/cgroupv2"
+	v2 "github.com/containers/common/pkg/cgroupv2"
 	"github.com/prometheus/procfs"
 	"golang.org/x/sys/unix"
 
@@ -488,7 +488,7 @@ func processMaps(pid int32) ([]*procfs.ProcMap, error) {
 func getCgroupPath() (string, error) {
 	cgroupPath := "/sys/fs/cgroup"
 
-	enabled, err := cgroupv2.Enabled()
+	enabled, err := v2.Enabled()
 	if !enabled {
 		if _, pathErr := os.Stat(filepath.Join(cgroupPath, "unified")); pathErr == nil {
 			slog.Debug("discovered hybrid cgroup hierarchy, will attempt to attach sockops")