Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[owasp-modsecurity compatibility] setsid action #1265

Open
tty2 opened this issue Jan 3, 2025 · 4 comments
Open

[owasp-modsecurity compatibility] setsid action #1265

tty2 opened this issue Jan 3, 2025 · 4 comments

Comments

@tty2
Copy link
Contributor

tty2 commented Jan 3, 2025

Summary

coraza doesn't implement setsid action
owasp-modsecurity has this action

Basic example

https://github.com/owasp-modsecurity/ModSecurity/wiki/Reference-Manual-(v3.x)#setsid

Motivation

OWASP modsecurity compatibility
@jptosso
Copy link
Member

jptosso commented Jan 3, 2025

This is under development, check #1261

@tty2
Copy link
Contributor Author

tty2 commented Jan 3, 2025 •
edited
Loading

Nice. Thanks @jptosso
Should I close this issue or you'll close it with merge?

Updated:
Wait. What?
It is our changes but there is no setsid action there. Did you attach a right pr?
Or you mean it can be implemented after this pr?

@jcchavezs
Copy link
Member

ping @jptosso

@jptosso
Copy link
Member

jptosso commented Jan 7, 2025

Sorry my bad, actually the persistence logic is implemented this should be a straightforward change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jptosso @jcchavezs @tty2