CORE-15778: add meaningful exception messages in StateRef.parse()

[jennyang-r3]

Overview

The PR

• added an exception in malformed value in StateRef where delimiter, ":", isn't in value.
• optimise the method by utilising an existing index exception.

Testing

I added a unit test for StateRef.parse() method, testing if:

• valid StateRef is parsed correctly
• value with zero delimiter throws a correct exception
• value with missing index throws a correct exception
• any other malformed value throws transaction Id exception

[corda-jenkins-ci02]

Jenkins build for PR 1199 build 12

Build Successful:
Jar artifact version produced by this PR: 5.1.0.12-alpha-1691482422220

[relyafi]

I've posted some specific comments, but having looked at the change as a whole, I wonder if there's a simpler solution. We're already parsing the hash, and verifying the index, so could the issue be solved by parsing the index before calling parseSecureHash? The index check could also probably be made a bit stronger by replacing the (now deprecated?) parseInt with toUInt?

I also think it's worth elaborating on the description, and adding test notes - @nkovacsx PR's are often good examples of this, e.g. corda/corda-runtime-os#4230

Finally, it feels like we're currently missing a unit test case if we were able to make this change without breaking any tests - I think it's worth adding a case to check that we get the expected error if a malformed state ref is passed in.

[vlajos]

LGTM

[relyafi]

LGTM

[driessamyn]

LGTM