Skip to content

Commit 46608a7

Browse files
NOTICK: Remove ExtendedStackTraceHotSpot
ExtendedStackTraceHotSpot is an alternative to ExtendedStackTrace/ExtendedStackTraceClassContext that only works on the Oracle JVM. This code path may have improved performance in the Oracle JVM. I would expect that removing this will make both JVMs perform equally. We already find the performance of OpenJDK acceptable so this should be an acceptable decrease for OracleJDK. Removing this gives us the same code paths on both JVMs. That means that testing on OpenJDK will be enough without setting up another environment to test the Oracle JDK paths. It also reduces the code we need to maintain.
1 parent 57c89cf commit 46608a7

File tree

3 files changed

+8
-352
lines changed

3 files changed

+8
-352
lines changed

quasar-core/src/main/java/co/paralleluniverse/common/util/ExtendedStackTrace.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,19 +32,11 @@
3232
*/
3333
public class ExtendedStackTrace implements Iterable<ExtendedStackTraceElement> {
3434
public static ExtendedStackTrace of(Throwable t) {
35-
try {
36-
return new ExtendedStackTraceHotSpot(t);
37-
} catch (Throwable e) {
38-
return new ExtendedStackTrace(t);
39-
}
35+
return new ExtendedStackTrace(t);
4036
}
4137

4238
public static ExtendedStackTrace here() {
43-
try {
44-
return new ExtendedStackTraceHotSpot(new Throwable());
45-
} catch (Throwable e) {
46-
return new ExtendedStackTraceClassContext();
47-
}
39+
return new ExtendedStackTraceClassContext();
4840
}
4941

5042
protected final Throwable t;

quasar-core/src/main/java/co/paralleluniverse/common/util/ExtendedStackTraceHotSpot.java

Lines changed: 0 additions & 303 deletions
This file was deleted.

0 commit comments

Comments
 (0)