Merge pull request #2 from coredac/lower_llvm

Lower mlir.llvm to neura

Author: tancheng

include/Conversion/LlvmToNeura/LlvmToNeura.h

@@ -0,0 +1,12 @@
+#ifndef NEURA_CONVERSION_LLVMTONEURA_LLVMTONEURAPASS_H
+#define NEURA_CONVERSION_LLVMTONEURA_LLVMTONEURAPASS_H
+
+#include "mlir/Pass/Pass.h"
+
+namespace mlir {
+namespace neura {
+  std::unique_ptr<Pass> createLowerLlvmToNeuraPass();
+} // namespace neura
+} // namespace mlir
+
+#endif // NEURA_CONVERSION_LLVMTONEURA_LLVMTONEURAPASS_H

lib/CMakeLists.txt

@@ -1,3 +1,3 @@
 add_subdirectory(NeuraDialect)
-add_subdirectory(Conversion/ArithToNeura)
+add_subdirectory(Conversion)
 add_subdirectory(Transforms)

…Conversion/ArithToNeura/ArithToNeura.cpp …ersion/ArithToNeura/ArithToNeuraPass.cpplib/Conversion/ArithToNeura/ArithToNeura.cpp renamed to lib/Conversion/ArithToNeura/ArithToNeuraPass.cpp lib/Conversion/ArithToNeura/ArithToNeura.cpp renamed to lib/Conversion/ArithToNeura/ArithToNeuraPass.cpp

@@ -27,7 +27,7 @@ struct LowerArithToNeuraPass
 
   StringRef getArgument() const override { return "lower-arith-to-neura"; }
   StringRef getDescription() const override {
-    return "Lower arithmetic operations to Neura dialect operations";
+    return "Lower arith dialect operations to Neura dialect operations";
   }
 
   void getDependentDialects(DialectRegistry &registry) const override {
@@ -36,11 +36,7 @@ struct LowerArithToNeuraPass
 
   void runOnOperation() override {
     RewritePatternSet patterns(&getContext());
-    llvm::errs() << "[cheng] check runOnOperation: ";
     getOperation().dump();
-    getOperation().walk([](Operation *op) {
-      llvm::errs() << "[cheng] Saw op: " << op->getName() << "\n";
-    });
     patterns.add<ArithAddFOpLowering>(&getContext());
     if (failed(applyPatternsAndFoldGreedily(getOperation(), std::move(patterns)))) {
       signalPassFailure();

lib/Conversion/ArithToNeura/CMakeLists.txt

@@ -1,5 +1,5 @@
 add_mlir_library(NeuraArithToNeura
-  ArithToNeura.cpp
+  ArithToNeuraPass.cpp
 
   DEPENDS
   NeuraOpsIncGen

lib/Conversion/CMakeLists.txt

@@ -0,0 +1,2 @@
+add_subdirectory(ArithToNeura)
+add_subdirectory(LlvmToNeura)

lib/Conversion/LlvmToNeura/CMakeLists.txt

@@ -0,0 +1,28 @@
+add_mlir_library(NeuraLlvmToNeura
+  LlvmToNeuraPass.cpp
+
+  DEPENDS
+  NeuraOpsIncGen
+  NeuraDialectIncGen
+  NeuraDialect
+
+  LINK_LIBS PUBLIC
+  MLIRArithDialect
+  MLIRFuncDialect
+  MLIRLLVMDialect
+  MLIRIR
+  MLIRPass
+  MLIRTransforms
+)
+
+target_include_directories(NeuraLlvmToNeura PUBLIC
+    ${CMAKE_BINARY_DIR}/lib/NeuraDialect
+    ${MLIR_INCLUDE_DIRS}
+    ${LLVM_INCLUDE_DIRS}
+    ${CMAKE_SOURCE_DIR}/include
+    ${CMAKE_BINARY_DIR}/include
+)
+
+target_compile_definitions(NeuraLlvmToNeura
+  PRIVATE ${LLVM_DEFINITIONS}
+)

lib/Conversion/LlvmToNeura/LlvmToNeuraPass.cpp

@@ -0,0 +1,51 @@
+#include "Conversion/LlvmToNeura/LlvmToNeura.h"
+#include "NeuraDialect/NeuraDialect.h"
+#include "NeuraDialect/NeuraOps.h"
+#include "mlir/Dialect/LLVMIR/LLVMAttrs.h"
+#include "mlir/Dialect/LLVMIR/LLVMDialect.h"
+#include "mlir/Dialect/LLVMIR/LLVMTypes.h"
+#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/IR/PatternMatch.h"
+#include "mlir/Pass/Pass.h"
+#include "mlir/Transforms/GreedyPatternRewriteDriver.h"
+
+using namespace mlir;
+
+namespace {
+struct LlvmAddFOpLowering : public OpRewritePattern<mlir::LLVM::FAddOp> {
+  using OpRewritePattern::OpRewritePattern;
+
+  LogicalResult matchAndRewrite(mlir::LLVM::FAddOp op,
+                                PatternRewriter &rewriter) const override {
+    rewriter.replaceOpWithNewOp<neura::AddOp>(op, op.getType(), op.getLhs(), op.getRhs());
+    return success();
+  }
+};
+
+struct LowerLlvmToNeuraPass
+    : public PassWrapper<LowerLlvmToNeuraPass, OperationPass<func::FuncOp>> {
+
+  MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(LowerLlvmToNeuraPass)
+
+  StringRef getArgument() const override { return "lower-llvm-to-neura"; }
+  StringRef getDescription() const override {
+    return "Lower LLVM operations to Neura dialect operations";
+  }
+
+  void getDependentDialects(DialectRegistry &registry) const override {
+    registry.insert<mlir::neura::NeuraDialect>();
+  }
+
+  void runOnOperation() override {
+    RewritePatternSet patterns(&getContext());
+    patterns.add<LlvmAddFOpLowering>(&getContext());
+    if (failed(applyPatternsAndFoldGreedily(getOperation(), std::move(patterns)))) {
+      signalPassFailure();
+    }
+  }
+};
+} // namespace
+
+std::unique_ptr<Pass> mlir::neura::createLowerLlvmToNeuraPass() {
+  return std::make_unique<LowerLlvmToNeuraPass>();
+}

test/neura/add.mlir test/neura/arith_add.mlirtest/neura/add.mlir renamed to test/neura/arith_add.mlir

@@ -0,0 +1,10 @@
+// RUN: mlir-neura-opt --lower-llvm-to-neura --insert-mov %s | FileCheck %s
+
+func.func @test(%a: f32) -> f32 {
+  %b = llvm.mlir.constant(2.0 : f32) : f32
+  %res = llvm.fadd %a, %b : f32
+  // CHECK: [[LHS:%.*]] = neura.mov %{{.*}} : f32 -> f32
+  // CHECK: [[RHS:%.*]] = neura.mov %{{.*}} : f32 -> f32
+  // CHECK: [[RES:%.*]] = neura.add [[LHS]], [[RHS]] : f32
+  return %res : f32
+}

test/neura/llvm_add.mlir

@@ -6,15 +6,17 @@ add_executable(mlir-neura-opt
 
 # Links MLIR libraries.
 target_link_libraries(mlir-neura-opt PRIVATE
-  MLIROptLib        # MLIR optimizer library
+  MLIRDialect       # MLIR Dialect
   MLIRIR            # MLIR Core IR
+  MLIRLLVMDialect
+  MLIROptLib        # MLIR optimizer library
   MLIRSupport       # MLIR Support utilities
   MLIRTransforms    # MLIR transformation passes
-  MLIRDialect       # MLIR Dialect
   NeuraDialect      # Custom dialect
   MLIRFuncDialect   # Builtin dialect required by custom dialect
   MLIRArithDialect
   NeuraArithToNeura
+  NeuraLlvmToNeura
   NeuraTransforms
 )