Testbench

[n0thingNoob]

This pull request introduces several improvements and extensions to the Neura architecture and code generation pipeline. The main changes are the addition of a local_id property for registers to distinguish local register identifiers from global ones, updates to register creation and usage to support local IDs, enhancements to mapping and code generation to track and use local register IDs, and the addition of new LLVM-to-Neura operation conversion patterns. It also adds support for including the compiled initiation interval (compiled_ii) in array configuration outputs.

Register ID improvements:

• Added a local_id property to the Register class, updated its constructor, and provided getter/setter methods. Register creation now assigns both global and local IDs, making register identification more robust. (include/NeuraDialect/Architecture/Architecture.h, lib/NeuraDialect/Architecture/Architecture.cpp) [1] [2] [3] [4] [5]
• Updated mapping state encoding to include both global and local register IDs in the mapping dictionary output. (lib/NeuraDialect/Mapping/MappingState.cpp)

Code generation and mapping updates:

• Modified code generation logic to use local_register_id instead of global IDs when collecting and mapping register steps, ensuring correct local register references in output. (lib/NeuraDialect/Transforms/GenerateCodePass.cpp) [1] [2]

LLVM-to-Neura operation conversion:

• Added new rewrite patterns to convert several LLVM operations to their Neura dialect equivalents, including XOR to OR, AND to MUL, FNeg to FSub, LShr to Shl (with negative shift), and Select to arithmetic ops. These patterns are registered in the conversion pipeline. (lib/Conversion/LlvmToNeura/LlvmToNeuraPass.cpp) [1] [2]

Array configuration and output enhancements:

• Added a compiled_ii field to ArrayConfig, updated output routines to include it in YAML and ASM files if available, and provided a helper to extract it from function attributes. (lib/NeuraDialect/Transforms/GenerateCodePass.cpp) [1] [2] [3] [4] [5] [6]

[Copilot]

Pull Request Overview

This PR enhances the Neura architecture and code generation pipeline by introducing local register identifiers alongside global IDs, expanding LLVM-to-Neura operation conversion patterns, and adding compiled initiation interval (II) tracking in array configurations.

Key changes:

• Introduced local_id property for registers to provide per-tile local register identification separate from global IDs
• Added five new LLVM-to-Neura conversion patterns (XOR→OR, AND→MUL, FNeg→FSub, LShr→Shl, Select→arithmetic ops)
• Added compiled_ii field to array configurations with corresponding YAML and ASM output support

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
include/NeuraDialect/Architecture/Architecture.h	Added local_id member and getter/setter methods to Register class
lib/NeuraDialect/Architecture/Architecture.cpp	Updated Register constructor to accept local_id; modified register creation to assign both global and local IDs
lib/NeuraDialect/Mapping/MappingState.cpp	Enhanced mapping state encoding to include both global and local register IDs in dictionary output
lib/NeuraDialect/Transforms/GenerateCodePass.cpp	Modified code generation to use local_register_id; added compiled_ii support to ArrayConfig and output functions
lib/Conversion/LlvmToNeura/LlvmToNeuraPass.cpp	Added five new conversion patterns and registered them in the conversion pipeline
test/neura/ctrl/branch_for.mlir	Updated test expectations to include compiled_ii field
test/mapping_quality/branch_for.mlir	Updated test expectations to include compiled_ii field
test/e2e/histogram/histogram_kernel.mlir	Updated test expectations to include local_register_id attributes and adjusted ASM output expectations
test/e2e/fir/fir_kernel_vec.mlir	Updated test expectations to include local_register_id attributes and adjusted ASM output expectations
test/e2e/fir/fir_kernel.mlir	Updated test expectations to include local_register_id attributes and adjusted ASM output expectations

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[n0thingNoob]

I forgot I have added some conversion rules to the pass. Let me fix that.