[Refactor] Introduce NeuraAttributes.h to manage attribute constants#241
Merged
tancheng merged 4 commits intocoredac:mainfrom Jan 20, 2026
Merged
[Refactor] Introduce NeuraAttributes.h to manage attribute constants#241tancheng merged 4 commits intocoredac:mainfrom
tancheng merged 4 commits intocoredac:mainfrom
Conversation
ShangkunLi
reviewed
Jan 18, 2026
tancheng
approved these changes
Jan 18, 2026
Contributor
tancheng
left a comment
tancheng
left a comment
There was a problem hiding this comment.
Thanks for the cleanup~!
Contributor
|
Can we also have following in the header file? https://github.com/coredac/dataflow/blob/2a6fdfa3375882ead687cda895002804c96094b3/lib/NeuraDialect/Transforms/GenerateCodePass.cpp#L204-L224 And anything introduced from https://github.com/coredac/dataflow/pull/157/changes |
HobbitQia
approved these changes
Jan 19, 2026
ShangkunLi
approved these changes
Jan 19, 2026
Contributor
Author
|
Hi @tancheng, thanks for the suggestions! I have addressed both points in the latest commits:
Please verify and resolve the conversation if it looks good. |
tancheng
approved these changes
Jan 20, 2026
Contributor
|
Thanks~! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses part of #145 by introducing a centralized header NeuraAttributes.h and replacing a subset of hardcoded magic strings in the lib/ directory.