Skip to content

Pattern fusion template#3

Merged
tancheng merged 4 commits intomainfrom
fuse_add_add
May 17, 2025
Merged

Pattern fusion template#3
tancheng merged 4 commits intomainfrom
fuse_add_add

Conversation

@tancheng
Copy link
Copy Markdown
Contributor

A pattern fusion template

  • With example about fadd-fadd.
  • I decide NOT go forward with:
    • user providing any fusion pattern
      • user needs to handle dependency, for large pattern, its complexity is same as writing up the pass/pattern_matcher
    • leverage tablegen
      • Same complexity as writing up pass, and sometimes out of control and less flexibility, and user needs to think more/deep
  • I decide to provide specific flag for each type of fusion.

@tancheng tancheng self-assigned this May 16, 2025
@tancheng tancheng added the new feature New feature or request label May 16, 2025
@tancheng tancheng mentioned this pull request May 16, 2025
1 task
@tancheng tancheng requested a review from HardyVon May 16, 2025 05:02
Copy link
Copy Markdown
Collaborator

@ShangkunLi ShangkunLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. ^_^

@tancheng
Copy link
Copy Markdown
Contributor Author

Everything looks good to me. ^_^

Thanks, plz approve the dependent one :-)

@tancheng tancheng merged commit fc63453 into main May 17, 2025
1 check passed
Copilot AI mentioned this pull request Nov 2, 2025
ShangkunLi pushed a commit that referenced this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants