Further cleanup

Signed-off-by: David A. Wheeler <[email protected]>

Author: david-a-wheeler

.rubocop.yml

@@ -265,3 +265,7 @@ Style/YodaExpression:
   Enabled: false
 Metrics/BlockLength:
   Max: 36
+Lint/RedundantRequireStatement:
+  Enabled: true  # Let RuboCop remove truly redundant requires
+Rails/WhereRange:
+  Enabled: true  # Modern Rails range syntax is cleaner and equivalent

app/controllers/projects_controller.rb

@@ -6,7 +6,6 @@
 
 require 'addressable/uri'
 require 'net/http'
-require 'set'
 
 # rubocop:disable Metrics/ClassLength
 class ProjectsController < ApplicationController

app/lib/chief.rb

@@ -13,8 +13,6 @@
 # the Detective INPUTS and OUTPUTS to determine what order to run, and
 # run them in parallel in an appropriate order.
 
-require 'set'
-
 # rubocop:disable Metrics/ClassLength
 class Chief
   # Confidence level (1..5) where automation result will *override*

app/lib/hardened_sites_detective.rb

@@ -6,8 +6,6 @@
 
 # Determine if project sites support HTTPS
 
-require 'set'
-
 class HardenedSitesDetective < Detective
   # All of the security-hardening headers that need to be present to pass.
   # They're listed in the same order as the criteria text.

app/models/badge.rb

@@ -4,8 +4,6 @@
 # OpenSSF Best Practices badge contributors
 # SPDX-License-Identifier: MIT
 
-require 'set'
-
 # rubocop: disable Metrics/ClassLength
 class Badge
   ACCEPTABLE_PERCENTAGES = (0..99).to_a.freeze

app/models/project.rb

@@ -536,7 +536,7 @@ def self.projects_to_remind
       .where('badge_percentage_0 < 100')
       .where('lost_passing_at IS NULL OR lost_passing_at < ?',
              LOST_PASSING_REMINDER.days.ago)
-      .where('projects.updated_at < ?', LAST_UPDATED_REMINDER.days.ago)
+      .where(projects: { updated_at: ...LAST_UPDATED_REMINDER.days.ago })
       .where('last_reminder_at IS NULL OR last_reminder_at < ?',
              LAST_SENT_REMINDER.days.ago)
       .joins(:user).references(:user) # Need this to check email address

config/initializers/rack_attack.rb

@@ -8,8 +8,6 @@
 
 # This assumes that "ClientIp.acquire" works correctly.
 
-require 'set'
-
 # Use recommended format of Rack::Attack config
 # rubocop: disable Style/ClassAndModuleChildren
 # rubocop: disable Style/IfUnlessModifier, Style/MethodCalledOnDoEndBlock

test/models/criteria_test.rb

@@ -5,7 +5,6 @@
 # SPDX-License-Identifier: MIT
 
 require 'test_helper'
-require 'set'
 
 # rubocop:disable Metrics/ClassLength
 class CriteriaTest < ActiveSupport::TestCase