install-badge-dev-env script fixes (#2148)

* fix 'case' syntax in install-badge-dev-env

Signed-off-by: Arnout Engelen <[email protected]>

* use https:// instead of git:// in install-badge-dev-env

unauthenticated git has been discontinued
https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-more-unauthenticated-git

Signed-off-by: Arnout Engelen <[email protected]>

---------

Signed-off-by: Arnout Engelen <[email protected]>

Author: raboof

install-badge-dev-env

@@ -160,7 +160,7 @@ case "$manager" in
   brew)
     # We'll use the brew version. Install these to rebuild rbenv:
     # add_pkg openssl libyaml libffi
-    add_pkg rbenv ruby-build graphviz postgres cmake
+    add_pkg rbenv ruby-build graphviz postgres cmake ;;
 
   apt-get)
     # We'll use the system version.  If you want to use the latest one
@@ -267,7 +267,7 @@ fi
 if [ "$DO_LOCAL_RBENV" = 'yes' ] ; then
   echo 'Downloading and installing rbenv from GitHub' >&2
   if ! [ -d ~/.rbenv ] ; then
-    git clone git://github.com/rbenv/rbenv.git ~/.rbenv
+    git clone https://github.com/rbenv/rbenv.git ~/.rbenv
   fi
   # Following performed in subshell so as not to change working directory.
   (
@@ -297,7 +297,7 @@ if [ "${MYINSTALL_RBENV_BUNDLER}" = 'yes' ] && \
    ! [ -e "$HOME/.rbenv/plugins/bundler" ] ; then
   echo 'Downloading and installing rbenv-bundler from GitHub' >&2
   mkdir -p "$HOME/.rbenv/plugins/"
-  git clone git://github.com/carsomyr/rbenv-bundler.git \
+  git clone https://github.com/carsomyr/rbenv-bundler.git \
             "$HOME/.rbenv/plugins/bundler"
 fi