From 5cb199a13f9142d7b4d6529fd6fe388dccfc965a Mon Sep 17 00:00:00 2001 From: Appu Date: Wed, 2 Feb 2022 12:29:13 -0500 Subject: [PATCH 1/2] Add minor error handling Not sure that this is strictly necessary here but helps debug a bit: adds an error if an empty `jwks_uri` is provided. --- oidc/oidc.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/oidc/oidc.go b/oidc/oidc.go index 3e1d80e0..6561ba2c 100644 --- a/oidc/oidc.go +++ b/oidc/oidc.go @@ -178,6 +178,11 @@ func NewProvider(ctx context.Context, issuer string) (*Provider, error) { algs = append(algs, a) } } + + if p.JWSKURL == "" { + return nil, fmt.Errorf("oidc: remote keys urls is empty") + } + return &Provider{ issuer: issuerURL, authURL: p.AuthURL, From 2b14933ea4d5b0ad789b241378225400cf9abb5f Mon Sep 17 00:00:00 2001 From: Appu Date: Wed, 2 Feb 2022 12:57:21 -0500 Subject: [PATCH 2/2] Update oidc.go --- oidc/oidc.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/oidc/oidc.go b/oidc/oidc.go index 6561ba2c..865f6e2c 100644 --- a/oidc/oidc.go +++ b/oidc/oidc.go @@ -179,7 +179,7 @@ func NewProvider(ctx context.Context, issuer string) (*Provider, error) { } } - if p.JWSKURL == "" { + if p.JWKSURL == "" { return nil, fmt.Errorf("oidc: remote keys urls is empty") }