refactor: split cli methods to easy testing #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felipe Zipitria <[email protected]>
theseion
requested changes
Jan 22, 2025
Co-authored-by: Max Leske <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
fzipi
force-pushed
the
refactor/split-cli-methods
branch
from
8b1991a to
4477d11
Compare
Signed-off-by: Felipe Zipitria <[email protected]>
fzipi
force-pushed
the
refactor/split-cli-methods
branch
from
4477d11 to
646208c
Compare
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
fzipi
force-pushed
the
refactor/split-cli-methods
branch
from
4db6a91 to
3b4b403
Compare
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
theseion
requested changes
Feb 9, 2025
Co-authored-by: Max Leske <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Co-authored-by: Max Leske <[email protected]>
Co-authored-by: Max Leske <[email protected]>
|
Ugh, the code review changes broke it. I'll try to fix. |
airween
reviewed
Feb 10, 2025
fzipi
force-pushed
the
refactor/split-cli-methods
branch
2 times, most recently
from
2a8ba08 to
0500fea
Compare
fzipi
force-pushed
the
refactor/split-cli-methods
branch
from
0500fea to
025f053
Compare
Signed-off-by: Felipe Zipitria <[email protected]>
fzipi
force-pushed
the
refactor/split-cli-methods
branch
from
025f053 to
3f10697
Compare
airween
reviewed
Feb 11, 2025
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
|
Can we focus on merge this one and then make additional modifications? I feel like if not this is never ending with additional requirements when the idea was to just make a refactor. |
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
theseion
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why