-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify corectness of template tests #85
Comments
I believe that the user agent needs to be changed to:
Was this modified at some point but the documentation didn't get updated? Also, it looks like the linter is unhappy for some reason with Accept headers, and they now require double-quote marks to work, so they need to be:
Although I note that the current example tests work fine in Go-FTW, no quote marks needed. Just the linter is unhappy for some reason. @fzipi, you're probably the best source of knowledge on how testing works. Can you confirm please that these changes are correct? We need to ensure that the template tests we provide are correct. |
I confirm on the UA change. Accept: Interesting. Funny thing is we use a crazy long Accept header for almost all existing tests. I would not mind cleaning this up to something much simpler. |
The Accept header thing is probably just because |
Every time that I copy-paste one of the agreed 'example tests' from the Contribution Guidelines document, my PR gets errors.
We need to verify that the template "gold standard" tests are correct.
Link to the test templates: https://github.com/coreruleset/documentation/blob/main/content/development/contribution_guidelines.md#positive-tests
The text was updated successfully, but these errors were encountered: