Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update example tests in contribution docs #86

Merged
merged 1 commit into from
May 6, 2023

Conversation

theseion
Copy link
Contributor

@theseion theseion commented May 2, 2023

Fixes #85

@theseion theseion requested a review from RedXanadu May 2, 2023 16:16
@dune73
Copy link
Member

dune73 commented May 5, 2023

Looks good to me. Anything to say before merging @RedXanadu?

@theseion theseion merged commit ae64c56 into coreruleset:main May 6, 2023
@theseion theseion deleted the update-example-tests branch May 6, 2023 06:58
@RedXanadu
Copy link
Member

RedXanadu commented May 22, 2023

Thank you for sorting this @theseion! I've only just seen this.

One question: what is "uri: "/post""? That looks new to me, and I don't know what it is. We don't have that documented, as far as I can see.

@theseion
Copy link
Contributor Author

httpbin has one dedicated endpoint for each HTTP method. Requests to / return status 200 but include a large HTML payload. Using the dedicated endpoints does not include any HTML and is thus preferable in terms of raw test throughput. Yes, that should be documented.

@theseion
Copy link
Contributor Author

See #92.

@dune73
Copy link
Member

dune73 commented May 26, 2023

Thanks for explanation and doc PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify corectness of template tests
3 participants