-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement multi-value headers #332
Labels
enhancement
New feature or request
Comments
theseion
added a commit
to theseion/go-ftw
that referenced
this issue
Jan 12, 2025
- support multiple headers with the same name - support multiple headers with identical name and value - make list of headers ordered; in the future, tests should be able to enforce the order of headers in a request - improve API, tests, and documentation of ftwhttp.Header - disable logging in tests where possible - enable self-updater test (go-critic was complaining because the test file was touched) Fixes coreruleset#332
theseion
added a commit
to theseion/go-ftw
that referenced
this issue
Jan 12, 2025
- support multiple headers with the same name - support multiple headers with identical name and value - make list of headers ordered; in the future, tests should be able to enforce the order of headers in a request - improve API, tests, and documentation of ftwhttp.Header - disable logging in tests where possible - enable self-updater test (go-critic was complaining because the test file was touched) Fixes coreruleset#332
theseion
added a commit
to theseion/go-ftw
that referenced
this issue
Jan 12, 2025
- support multiple headers with the same name - support multiple headers with identical name and value - make list of headers ordered; in the future, tests should be able to enforce the order of headers in a request - improve API, tests, and documentation of ftwhttp.Header - disable logging in tests where possible - enable self-updater test (go-critic was complaining because the test file was touched) Fixes coreruleset#332
theseion
added a commit
to theseion/go-ftw
that referenced
this issue
Jan 12, 2025
- support multiple headers with the same name - support multiple headers with identical name and value - make list of headers ordered; in the future, tests should be able to enforce the order of headers in a request - improve API, tests, and documentation of ftwhttp.Header - disable logging in tests where possible - enable self-updater test (go-critic was complaining because the test file was touched) Fixes coreruleset#332
theseion
added a commit
to theseion/go-ftw
that referenced
this issue
Feb 3, 2025
- support multiple headers with the same name - support multiple headers with identical name and value - make list of headers ordered; in the future, tests should be able to enforce the order of headers in a request - improve API, tests, and documentation of ftwhttp.Header - disable logging in tests where possible - enable self-updater test (go-critic was complaining because the test file was touched) Fixes coreruleset#332
theseion
added a commit
to theseion/go-ftw
that referenced
this issue
Feb 15, 2025
- support multiple headers with the same name - support multiple headers with identical name and value - make list of headers ordered; in the future, tests should be able to enforce the order of headers in a request - improve API, tests, and documentation of ftwhttp.Header - disable logging in tests where possible - enable self-updater test (go-critic was complaining because the test file was touched) Fixes coreruleset#332
theseion
added a commit
to theseion/go-ftw
that referenced
this issue
Feb 17, 2025
- support multiple headers with the same name - support multiple headers with identical name and value - make list of headers ordered; in the future, tests should be able to enforce the order of headers in a request - improve API, tests, and documentation of ftwhttp.Header - disable logging in tests where possible - enable self-updater test (go-critic was complaining because the test file was touched) Fixes coreruleset#332
theseion
added a commit
to theseion/go-ftw
that referenced
this issue
Feb 25, 2025
- support multiple headers with the same name - support multiple headers with identical name and value - make list of headers ordered; in the future, tests should be able to enforce the order of headers in a request - improve API, tests, and documentation of ftwhttp.Header - disable logging in tests where possible - enable self-updater test (go-critic was complaining because the test file was touched) Fixes coreruleset#332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
Header
type currently doesn't support multiple values for a single header. We need to support requests that include the same header multiple times, possibly with different casings. Examples:Attackers will throw anything at a web server to break it / break in. That means a web server will see requests that are not valid w.r.t. to RFCs. In this case, the web server might see multiple entries for the same header, with differences in the header name and / or the header value, as shown in the examples above. go-ftw must be able to send such requests in order to test that a WAF can defend against them.
Acceptance criteria
Header
must not be an alias formap[string]string
. Users must be forced to use the methods to ensure proper state of the objectThe text was updated successfully, but these errors were encountered: