Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking backward compatibility changes #442

Open
tty2 opened this issue Jan 6, 2025 · 5 comments
Open

Breaking backward compatibility changes #442

tty2 opened this issue Jan 6, 2025 · 5 comments

Comments

@tty2
Copy link

tty2 commented Jan 6, 2025

Looks like the version 1.2.0 should be updated to v2.0.0
There are breaking changes here

Look the result for coraza
corazawaf/coraza#1276

@tty2 tty2 changed the title Breaking backword compatiblity changes. Breaking backward compatibility changes. Jan 6, 2025
@theseion theseion changed the title Breaking backward compatibility changes. Breaking backward compatibility changes Jan 6, 2025
@theseion
Copy link
Collaborator

theseion commented Jan 6, 2025

Thanks @tty2. You're right. I always forget that Coraza uses go-ftw as a dependency. Given that you've already opened a PR to fix this in Coraza, I don't think we need to update the version for go-ftw this time. Would you agree?

We'll be more careful with breaking changes in the future.

@tty2
Copy link
Author

tty2 commented Jan 6, 2025

Hey @theseion
I don't mind both ways, that's why I opened PR and issue.
The right way to change go-ftw (IMHO) because there is a possibility that not only coraza uses go-ftw.
I'd ask for other maintainers opinion.

@theseion
Copy link
Collaborator

theseion commented Jan 6, 2025

@fzipi thoughts?

@fzipi
Copy link
Member

fzipi commented Jan 11, 2025

We should go for a new major probably, and make this clear in new PRs when something is breaking so we upgrade properly.

@theseion
Copy link
Collaborator

I agree... But would you rerelease this version as a major? I would just leave it, it's already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants