Skip to content

Commit 11348ce

Browse files
authored
Bug Fix: (#73)
- When using the stats + query builder in a notebook env, there was some double url encoding happening which was breaking the request. - Removes __version.py file, as it not needed
1 parent 503a7e8 commit 11348ce

File tree

4 files changed

+27
-6
lines changed

4 files changed

+27
-6
lines changed

README.md

+24
Original file line numberDiff line numberDiff line change
@@ -373,3 +373,27 @@ $ ruff .
373373
$ black .
374374

375375
```
376+
377+
378+
#### Poetry version management
379+
```
380+
# View current version
381+
poetry version
382+
383+
# Bump version
384+
poetry version patch # 0.1.0 -> 0.1.1
385+
poetry version minor # 0.1.0 -> 0.2.0
386+
poetry version major # 0.1.0 -> 1.0.0
387+
388+
# Set specific version
389+
poetry version 2.0.0
390+
391+
# Set pre-release versions
392+
poetry version prepatch # 0.1.0 -> 0.1.1-alpha.0
393+
poetry version preminor # 0.1.0 -> 0.2.0-alpha.0
394+
poetry version premajor # 0.1.0 -> 1.0.0-alpha.0
395+
396+
# Specify pre-release identifier
397+
poetry version prerelease # 0.1.0 -> 0.1.0-alpha.0
398+
poetry version prerelease beta # 0.1.0-alpha.0 -> 0.1.0-beta.0
399+
```

nhlpy/_version.py

-3
This file was deleted.

nhlpy/api/stats.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ def skater_stats_with_query_context(
245245
penaltykill, penaltyShots, powerplay, puckPossessions, summaryshooting, percentages, scoringRates,
246246
scoringpergame, shootout, shottype, timeonice
247247
:param query_context:
248-
:param aggregate: bool - If doing multiple years, you can choose to aggreate the date per player,
248+
:param aggregate: bool - If doing multiple years, you can choose to aggregate the date per player,
249249
or have separate entries for each one.
250250
:param sort_expr: A list of key/value pairs for sort criteria. As used in skater_stats_summary(), this is
251251
in the format:
@@ -269,7 +269,7 @@ def skater_stats_with_query_context(
269269
if not sort_expr:
270270
sort_expr = SortingOptions.get_default_sorting_for_report(report_type)
271271

272-
q_params["sort"] = urllib.parse.quote(json.dumps(sort_expr))
272+
q_params["sort"] = json.dumps(sort_expr)
273273
q_params["cayenneExp"] = query_context.query_str
274274
return self.client.get_by_url(
275275
f"https://api.nhle.com/stats/rest/en/skater/{report_type}", query_params=q_params

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
44

55
[tool.poetry]
66
name = "nhl-api-py"
7-
version = "2.11.0"
7+
version = "2.11.1"
88
description = "NHL API (Updated for 2024/2025) and EDGE Stats. For standings, team stats, outcomes, player information. Contains each individual API endpoint as well as convience methods as well as pythonic query builder for more indepth EDGE stats."
99
authors = ["Corey Schaf <[email protected]>"]
1010
readme = "README.md"

0 commit comments

Comments
 (0)