-
-
Notifications
You must be signed in to change notification settings - Fork 104
Improve allocation caching #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nkoppel
wants to merge
23
commits into
chelsea0x3b:main
Choose a base branch
from
nkoppel:caching
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
935810f
improve TensorCache api; move buffer conversion logic to CacheStorage
nkoppel 0a2d7d9
split an assert; run cargo fmt
nkoppel 347b24b
reduce visibility of internals; add safety comments
nkoppel f055ae5
create safe wrapper around CacheStorage objects
nkoppel 1697002
run cargo fmt
nkoppel 240553c
add check_key method to ensure CacheWrappers are used with valid keys
nkoppel 101497e
typo; run cargo fmt
nkoppel ea73294
add shrink method
nkoppel 9efc215
document ignore_drops; fix constraint violations
nkoppel e99a2ae
fix another constraint violation; fix TensorCache::len
nkoppel 76798c9
add size parameter to enable_cache and add set_cache_size
nkoppel e1f4622
remove len argument from TensorCache::insert; add test for cache
nkoppel 7476b80
run cargo fmt
nkoppel 80c20e7
fix clippy error
nkoppel ed24740
Merge branch 'main' into caching
nkoppel 3d443ba
remove debug print statements
nkoppel 9761e41
improve documentation
nkoppel aef3be9
add 'in bytes' to enable_cache documentation
nkoppel 59ed3b1
add CacheSize enum
nkoppel 902529e
run cargo fmt
nkoppel a2a565d
further clarify comment; remove align to 16 check
nkoppel 58518e2
add check to minimize RwLock operations in shrink; export CacheSize
nkoppel 5a03b08
run cargo fmt
nkoppel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.