From 7101279ca7ddb27a859a285b141c3fa5fe87ecde Mon Sep 17 00:00:00 2001 From: James Manners Date: Wed, 24 Aug 2022 00:10:35 +1000 Subject: [PATCH] types: vtkObject type definition (#182) * Update type definition for vtkObject * update api docs * dont cache netlify build --- common/reviews/api/core.api.md | 2 +- .../core/src/RenderingEngine/vtkClasses/vtkSlabCamera.d.ts | 4 ++-- packages/docs/netlify.toml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/common/reviews/api/core.api.md b/common/reviews/api/core.api.md index d52d7c8bc8..ae5f716e58 100644 --- a/common/reviews/api/core.api.md +++ b/common/reviews/api/core.api.md @@ -10,7 +10,7 @@ import type vtkActor from '@kitware/vtk.js/Rendering/Core/Actor'; import type { vtkCamera } from '@kitware/vtk.js/Rendering/Core/Camera'; import type { vtkImageData } from '@kitware/vtk.js/Common/DataModel/ImageData'; import vtkImageSlice from '@kitware/vtk.js/Rendering/Core/ImageSlice'; -import type { VtkObject } from '@kitware/vtk.js/interfaces'; +import type { vtkObject } from '@kitware/vtk.js/interfaces'; import vtkPlane from '@kitware/vtk.js/Common/DataModel/Plane'; import type vtkVolume from '@kitware/vtk.js/Rendering/Core/Volume'; diff --git a/packages/core/src/RenderingEngine/vtkClasses/vtkSlabCamera.d.ts b/packages/core/src/RenderingEngine/vtkClasses/vtkSlabCamera.d.ts index 2ebfd058ec..e644c586f0 100644 --- a/packages/core/src/RenderingEngine/vtkClasses/vtkSlabCamera.d.ts +++ b/packages/core/src/RenderingEngine/vtkClasses/vtkSlabCamera.d.ts @@ -1,5 +1,5 @@ import type { mat4 } from 'gl-matrix'; -import type { VtkObject } from '@kitware/vtk.js/interfaces'; +import type { vtkObject } from '@kitware/vtk.js/interfaces'; // Copied from VTKCamera @@ -29,7 +29,7 @@ interface ICameraInitialValues { physicalViewNorth?: number[]; } -export interface vtkSlabCamera extends VtkObject { +export interface vtkSlabCamera extends vtkObject { /** * Apply a transform to the camera. * The camera position, focal-point, and view-up are re-calculated diff --git a/packages/docs/netlify.toml b/packages/docs/netlify.toml index 3e029bac56..589812f425 100644 --- a/packages/docs/netlify.toml +++ b/packages/docs/netlify.toml @@ -9,7 +9,7 @@ publish = "build" # Rebuild if anything changes, don't scope to this folder - ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../../" + # ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../../" # COMMENT: NODE_VERSION in root `.nvmrc` takes priority # COMMENT: Why we specify YARN_FLAGS: https://www.netlify.com/docs/build-gotchas/#yarn