Skip to content
This repository was archived by the owner on Apr 28, 2020. It is now read-only.

Commit 6d26945

Browse files
authored
Merge pull request #14 from ganlanyuan/fix-import-url
fixes from jesstelford
2 parents 751c664 + 3364be7 commit 6d26945

16 files changed

+1213
-9
lines changed

config.codekit

Lines changed: 1123 additions & 0 deletions
Large diffs are not rendered by default.

selectivizr2.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363

6464
// Stylesheet parsing regexp's
6565
var RE_COMMENT = /(\/\*[^*]*\*+([^\/][^*]*\*+)*\/)\s*?/g;
66-
var RE_IMPORT = /@import\s*(?:(?:(?:url\(\s*(['"]?)(.*)\1)\s*\))|(?:(['"])(.*)\3))\s*([^;]*);/g;
66+
var RE_IMPORT = /@import\s*(?:(?:(?:url\(\s*(['"]?)([^;]*)\1)\s*\))|(?:(['"])([^;]*)\3))\s*([^;]*);/g;
6767
var RE_ASSET_URL = /(behavior\s*?:\s*)?\burl\(\s*(["']?)(?!data:)([^"')]+)\2\s*\)/g;
6868
var RE_PSEUDO_STRUCTURAL = /^:(empty|(first|last|only|nth(-last)?)-(child|of-type))$/;
6969
var RE_PSEUDO_ELEMENTS = /:(:first-(?:line|letter))/g;

tests/master/css/import-print.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* if @media type filtering doesn't work we want this test to fail */
22

33
tr#import-print {
4-
background: #c00;
4+
background: #0c0;
55
}
66

tests/master/css/master.css

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,25 @@
2929
@import url("import-print.css") print;
3030
@import url("import-screen.css") screen;
3131

32-
#import-print {
33-
background: #0c0;
34-
}
32+
/* When parsing @import of minified CSS, ensure the Regex isn't too greedy */
33+
@import url("min-import-url-quoted-double.css");.minified{background:url("css/nested/test.png");}
34+
@import url('min-import-url-quoted-single.css');.minified{background:url("css/nested/test.png");}
35+
@import url(min-import-url-unquoted.css);.minified{background:url("css/nested/test.png");}
36+
@import "min-import-quoted-double.css";.minified{background:url("css/nested/test.png");}
37+
@import "min-import-quoted-single.css";.minified{background:url("css/nested/test.png");}
38+
@import url("nested/min-import-url-relative-path.css");.minified{background:url("css/nested/test.png");}
39+
/*
40+
* The following urls will be specific to your own server configuration and will fail
41+
* if used "out of the box". To test root-relative and fully qualifed url's you will
42+
* need to adjust the paths below:
43+
*/
3544

36-
#import-screen {
37-
background: #c00;
38-
}
45+
@import url("/selectivizr-git/tests/master/css/min-import-url-root-relative-path.css");.minified{background:url("css/nested/test.png");}
46+
@import url("http://iis/selectivizr-git/tests/master/css/min-import-url-fully-qualified-path.css");.minified{background:url("css/nested/test.png");}
47+
@import url("//iis/selectivizr-git/tests/master/css/min-import-url-protocol-relative-path.css");.minified{background:url("css/nested/test.png");}
48+
49+
@import url("min-import-print.css") print;.minified{background:url("css/nested/test.png");}
50+
@import url("min-import-screen.css") screen;.minified{background:url("css/nested/test.png");}
3951

4052
body {
4153
padding: 10px;
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
/* if @media type filtering doesn't work we want this test to fail */
2+
3+
tr#min-import-print {
4+
background: #0c0;
5+
}
6+
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
#min-import-quoted-double { background-color: #0c0 }
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
#min-import-quoted-single { background-color: #0c0 }
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
tr#min-import-screen {
2+
background: #0c0;
3+
}
4+
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
#min-import-url-fully-qualfied { background-color: #0c0 }
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
#min-import-url-protocol-relative {
2+
background: #0c0;
3+
}

0 commit comments

Comments
 (0)