From ecf9d68c09ccfd3f2d89b1ff7b97f5dfda197ac6 Mon Sep 17 00:00:00 2001 From: Don Cross Date: Tue, 11 Feb 2025 14:16:14 -0500 Subject: [PATCH] Env: Default RES knob to 0.25. Better tooltip for center frequency. --- src/env_pitch_detect.hpp | 4 +++- src/env_vcv.cpp | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/env_pitch_detect.hpp b/src/env_pitch_detect.hpp index 3083049..e0cadbb 100644 --- a/src/env_pitch_detect.hpp +++ b/src/env_pitch_detect.hpp @@ -183,6 +183,8 @@ namespace Sapphire info.resize(maxChannels); setThreshold(); setSpeed(); + setFrequency(); + setResonance(); initialize(); } @@ -213,7 +215,7 @@ namespace Sapphire q.pitchFilter.setFrequency(knob); } - void setResonance(value_t knob = 0) + void setResonance(value_t knob = 0.25) { for (info_t& q : info) q.pitchFilter.setResonance(knob); diff --git a/src/env_vcv.cpp b/src/env_vcv.cpp index 8bf55ef..2c1312a 100644 --- a/src/env_vcv.cpp +++ b/src/env_vcv.cpp @@ -57,8 +57,8 @@ namespace Sapphire config(PARAMS_LEN, INPUTS_LEN, OUTPUTS_LEN, LIGHTS_LEN); configControlGroup("Threshold", THRESHOLD_PARAM, THRESHOLD_ATTEN, THRESHOLD_CV_INPUT, -96, 0, -24, " dB"); configControlGroup("Speed", SPEED_PARAM, SPEED_ATTEN, SPEED_CV_INPUT, 0, 1, 0.5); - configControlGroup("Frequency", FREQ_PARAM, FREQ_ATTEN, FREQ_CV_INPUT, -Gravy::OctaveRange, +Gravy::OctaveRange, Gravy::DefaultFrequencyKnob); - configControlGroup("Resonance", RES_PARAM, RES_ATTEN, RES_CV_INPUT, 0, 1, Gravy::DefaultResonanceKnob); + configControlGroup("Center frequency", FREQ_PARAM, FREQ_ATTEN, FREQ_CV_INPUT, -Gravy::OctaveRange, +Gravy::OctaveRange, Gravy::DefaultFrequencyKnob); + configControlGroup("Resonance", RES_PARAM, RES_ATTEN, RES_CV_INPUT, 0, 1, 0.25); configInput(AUDIO_INPUT, "Audio"); configOutput(ENVELOPE_OUTPUT, "Envelope"); configOutput(PITCH_OUTPUT, "Pitch V/OCT");